Tweak some diagnostic spans #59084

estebank · 2019-03-11T02:48:15Z

No description provided.

rust-highfive · 2019-03-11T02:48:18Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

estebank · 2019-03-11T02:48:38Z

r? @davidtwco

davidtwco

LGTM, one minor question, feel free to r=me.

davidtwco · 2019-03-11T10:35:43Z

src/librustc_resolve/lib.rs

@@ -5115,7 +5115,7 @@ impl<'a> Resolver<'a> {
                        // extra for the comma.
                        span.lo().0 - (prev_comma.as_bytes().len() as u32) - 1
                    ));
-                    err.span_suggestion(
+                    err.tool_only_span_suggestion(


I'm unsure about this change. I agree that it makes the error much cleaner, but without the help: ... message how would someone know that they can automatically have the problem fixed?

(as a slight aside, I think we should try use try cc groups like @rust-lang/wg-diagnostics when landing PRs like this or the one that introduced tool_only_span_suggestion - I had no idea this existed and it'd have been nice to follow along with it)

tool_only_span_diagnostics was landed over the all hands because it was needed for a different change, so it's pretty recent.

Tools still will see the same json output, so vscode and rustfix would still be able to apply these. I guess I hadn't thought of the use case of someone running rustfix after running rustc iteratively. Should we mark these some other way? Cyan asterisk next to the error or something?

My only concern is that users who know when they see help: ... that it is something that can be automatically applied won't know that for this error.

Something like a cyan asterisk would be ideal to draw attention to that (it might even raise awareness of rustfix being able to fix these things if everyone's error messages had a cyan asterisk suddenly appear). I wouldn't block this PR on that, so I'll r+ this and we can file a follow-up.

Filed #59103.

davidtwco · 2019-03-11T15:00:51Z

@bors r+

bors · 2019-03-11T15:00:54Z

📌 Commit 63432949565d73020222ba99fb487f855b4b0565 has been approved by davidtwco

estebank · 2019-03-11T16:52:06Z

@davidtwco added a small tweak to fix some less than stellar spans and marked the other duplicate import suggestion as tool only.

@bors r=davidtwco

bors · 2019-03-11T16:52:07Z

📌 Commit a00fa50a3a47274416a3a1d404eb3a3a3afaba07 has been approved by davidtwco

estebank · 2019-03-12T18:37:56Z

@bors r=davidtwco rebased

bors · 2019-03-12T18:37:57Z

📌 Commit f1ee5bb2c5029a452c7ae8f465f87e3278a640c9 has been approved by davidtwco

bors · 2019-03-17T00:11:19Z

☔ The latest upstream changes (presumably #58899) made this pull request unmergeable. Please resolve the merge conflicts.

estebank · 2019-03-17T04:06:54Z

@bors r=davidtwco

bors · 2019-03-17T04:06:55Z

📌 Commit d1656f1 has been approved by davidtwco

Tweak some diagnostic spans

bors · 2019-03-23T05:58:20Z

☔ The latest upstream changes (presumably #58929) made this pull request unmergeable. Please resolve the merge conflicts.

estebank · 2019-03-23T21:12:34Z

@bors r=davidtwco

bors · 2019-03-23T21:12:35Z

📌 Commit 59f0f2e has been approved by davidtwco

bors · 2019-03-23T22:26:19Z

⌛ Testing commit 59f0f2e with merge 93f5ba0...

Tweak some diagnostic spans

bors · 2019-03-24T01:45:09Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: davidtwco
Pushing 93f5ba0 to master...

rust-highfive assigned cramertj Mar 11, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2019

rust-highfive assigned davidtwco and unassigned cramertj Mar 11, 2019

davidtwco reviewed Mar 11, 2019

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2019

davidtwco mentioned this pull request Mar 11, 2019

Highlight when errors have automatically applicable suggestions #59103

Open

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2019

estebank force-pushed the diagnostic-spans branch from a00fa50 to f1ee5bb Compare March 12, 2019 17:57

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 17, 2019

estebank force-pushed the diagnostic-spans branch from f1ee5bb to b53ca90 Compare March 17, 2019 00:46

This comment has been minimized.

Sign in to view

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 17, 2019

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 17, 2019

sanxiyn added a commit to sanxiyn/rust that referenced this pull request Mar 18, 2019

Rollup merge of rust-lang#59084 - estebank:diagnostic-spans, r=davidtwco

02c2e84

Tweak some diagnostic spans

sanxiyn mentioned this pull request Mar 18, 2019

Rollup of 8 pull requests #59271

Closed

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 22, 2019

Rollup merge of rust-lang#59084 - estebank:diagnostic-spans, r=davidtwco

ae89abd

Tweak some diagnostic spans

Mark-Simulacrum mentioned this pull request Mar 22, 2019

Rollup of 22 pull requests #59364

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 23, 2019

estebank added 10 commits March 23, 2019 13:05

Tweak spans for E0599

1b0ab0b

Swap const evaluation lint spans to point at problem in primary span

8e04395

Swap primary/secondary spans for E0458

e1be8b0

Tweak unsupported negative trait bounds message

9bfb0ef

Tweak unnecessary import suggestion

3211f38

Hide obvious suggestion from cli output

4473027

Deduplicate const eval error spans for better output

ce90db1

Mark duplicate import removal suggestion tool only

0a4ecf3

Fix rebase

81394ce

Fix span after rebase

59f0f2e

estebank force-pushed the diagnostic-spans branch from d1656f1 to 59f0f2e Compare March 23, 2019 21:10

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2019

bors added a commit that referenced this pull request Mar 23, 2019

Auto merge of #59084 - estebank:diagnostic-spans, r=davidtwco

93f5ba0

Tweak some diagnostic spans

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 24, 2019

bors merged commit 59f0f2e into rust-lang:master Mar 24, 2019

estebank deleted the diagnostic-spans branch November 9, 2023 05:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tweak some diagnostic spans #59084

Tweak some diagnostic spans #59084

estebank commented Mar 11, 2019

rust-highfive commented Mar 11, 2019

estebank commented Mar 11, 2019

davidtwco left a comment

davidtwco Mar 11, 2019 •

edited

Loading

estebank Mar 11, 2019

davidtwco Mar 11, 2019

davidtwco Mar 11, 2019

davidtwco commented Mar 11, 2019

bors commented Mar 11, 2019

estebank commented Mar 11, 2019

bors commented Mar 11, 2019

This comment has been minimized.

estebank commented Mar 12, 2019

bors commented Mar 12, 2019

bors commented Mar 17, 2019

This comment has been minimized.

estebank commented Mar 17, 2019

bors commented Mar 17, 2019

bors commented Mar 23, 2019

estebank commented Mar 23, 2019

bors commented Mar 23, 2019

bors commented Mar 23, 2019

bors commented Mar 24, 2019

Tweak some diagnostic spans #59084

Tweak some diagnostic spans #59084

Conversation

estebank commented Mar 11, 2019

rust-highfive commented Mar 11, 2019

estebank commented Mar 11, 2019

davidtwco left a comment

Choose a reason for hiding this comment

davidtwco Mar 11, 2019 • edited Loading

Choose a reason for hiding this comment

estebank Mar 11, 2019

Choose a reason for hiding this comment

davidtwco Mar 11, 2019

Choose a reason for hiding this comment

davidtwco Mar 11, 2019

Choose a reason for hiding this comment

davidtwco commented Mar 11, 2019

bors commented Mar 11, 2019

estebank commented Mar 11, 2019

bors commented Mar 11, 2019

This comment has been minimized.

estebank commented Mar 12, 2019

bors commented Mar 12, 2019

bors commented Mar 17, 2019

This comment has been minimized.

estebank commented Mar 17, 2019

bors commented Mar 17, 2019

bors commented Mar 23, 2019

estebank commented Mar 23, 2019

bors commented Mar 23, 2019

bors commented Mar 23, 2019

bors commented Mar 24, 2019

davidtwco Mar 11, 2019 •

edited

Loading