Add NAN test to docs #59327
Merged
Add NAN test to docs #59327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Kimundi (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
tesuji
reviewed
Mar 21, 2019
| @@ -970,6 +970,7 @@ impl f32 { | |||
| /// assert!((-3.0f32).clamp(-2.0f32, 1.0f32) == -2.0f32); | |||
| /// assert!((0.0f32).clamp(-2.0f32, 1.0f32) == 0.0f32); | |||
| /// assert!((2.0f32).clamp(-2.0f32, 1.0f32) == 1.0f32); | |||
| /// assert!((std::f32::NAN).clamp(-2.0f32, 1.0f32).is_nan()); | |||
| /// ``` | |||
There was a problem hiding this comment.
I think we may use assert_eq macro for those assertions.
There was a problem hiding this comment.
For the ones other than the new one, I agree, but because that's existing stuff, I don't think we need to block this PR landing for that.
|
Thanks! @bors r+ rollup |
|
📌 Commit 72f5d91 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Mar 22, 2019
Add NAN test to docs Documents and tests NAN behavior for the new (f32, f64)::clamp function.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 22, 2019
Add NAN test to docs Documents and tests NAN behavior for the new (f32, f64)::clamp function.
bors
added a commit
that referenced
this pull request
Mar 22, 2019
Rollup of 18 pull requests Successful merges: - #59106 (Add peer_addr function to UdpSocket) - #59170 (Add const generics to rustdoc) - #59172 (Update and clean up several parts of CONTRIBUTING.md) - #59190 (consistent naming for Rhs type parameter in libcore/ops) - #59236 (Rename miri component to miri-preview) - #59266 (Do not complain about non-existing fields after parse recovery) - #59273 (some small HIR doc improvements) - #59291 (Make Option<ThreadId> no larger than ThreadId, with NonZeroU64) - #59297 (convert field/method confusion help to suggestions) - #59304 (Move some bench tests back from libtest) - #59309 (Add messages for different verbosity levels. Output copy actions.) - #59321 (Unify E0109, E0110 and E0111) - #59322 (Tweak incorrect escaped char diagnostic) - #59323 (use suggestions for "enum instead of variant" error) - #59327 (Add NAN test to docs) - #59329 (cleanup: Remove compile-fail-fulldeps directory again) - #59347 (Move one test from run-make-fulldeps to ui) - #59360 (Add tracking issue number for `seek_convenience`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents and tests NAN behavior for the new (f32, f64)::clamp function.