Rollup some PRs in the queue #22367
Merged
Rollup some PRs in the queue #22367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to @dotdash it enables more aggressive optimizations from LLVM
In `std::f32` and `std::f64`: - `MIN_VALUE` → `MIN` - `MAX_VALUE` → `MAX` - `MIN_POS_VALUE` → `MIN_POSITIVE` This matches the corresponding integer constants. [breaking-change]
The quick start already links to the book. I think its not necessary to do in the build instructions.
Also add address of IRC server. Addresses rust-lang#22249.
Remove incorrect claim, add example, reformat and re-word. Fixes rust-lang#22266
Rollup merge (373cbab) of PR rust-lang#20723 accidentally reverted a portion of commit 8327bcc which shifted `slicing_syntax` from Active to Accepted.
We use them in some places, but never actually talk about the syntax.
Added a second note about keeping the reference.md list up-to-date to the bottom of the list, since not everyone (including me) reads the big comment at the top of it. :) Ensured that the feature gate list in reference.md is kept in alphabetical order.
if found on the `main()` function. This lets you write tests that live in `compile-fail` but are expected to compile successfully. This is handy when you have many small variations on a theme that you want to keep together, and you are just testing the type checker, not the runtime semantics.
This isn't something we want to guarantee.
It's not clear what this means, because a macro in item position can expand to zero or more items. For now we disallow it, which is technically a
[breaking-change]
but is landing without an RFC. The `pub` keyword previously had no effect, which seems quite unintended.
Fixes rust-lang#18317.
Fixes rust-lang#14660.
Highlights:
* Adds an 'uninstall.sh' script to `/usr/local/lib/rustlib/uninstall.sh`, the path to which is printed during installation.
* Components can be deselected during install, like `install.sh --without=rust-docs`.
* Components can be listed with `install.sh --list-components`.
* Vastly reduces spew during install (but supporting a `--verbose` option).
Typicall install run looks like:
```
brian@brianX1:~/dev/multirust⟫ sudo ./install.sh
[sudo] password for brian:
install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'cargo'
install: installing component 'rust-docs'
Rust is ready to roll.
```
Needs to be merged right before corresponding PRs to cargo and rust-packaging.
Fixes rust-lang#21117
Fixes rust-lang#20283
|
@bors r+ 1412911 |
|
@bors r+ f0f8be2 |
|
⌛ Testing commit f0f8be2 with merge a43d6f4... |
|
I hope this works for you. I've been trying for a few days and it passes locally but fails on Windows... |
|
Hmm. I removed the cloned PR since it seemed to be causing repeated failures. If it's still an issue I'll look further. Thanks! |
|
💔 Test failed - auto-linux-64-nopt-t |
|
@bors: r+ ac32f38 p=1 |
|
⌛ Testing commit ac32f38 with merge 2ac8138... |
|
💔 Test failed - auto-linux-64-nopt-t |
| unsafe { | ||
| rl_prompt = prompt.as_ptr(); | ||
|
|
||
| println!("{}", rl_prompt); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(still testing locally)