Forbid pub mymacro!();
#22285
Merged
Forbid pub mymacro!();
#22285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nick29581 (rust_highfive has picked a reviewer for you, use r? to override) |
|
I'd like an rpass test that has a pub item inside the macro body (I'm sure this will pass now, but it seems like something that could be broken by a different implementation). r+ with that. |
It's not clear what this means, because a macro in item position can expand to
zero or more items. For now we disallow it, which is technically a
[breaking-change]
but is landing without an RFC. The `pub` keyword previously had no effect,
which seems quite unintended.
Fixes rust-lang#18317.
Fixes rust-lang#14660.
kmcallister
force-pushed
the
pub-macro
branch
from
1cdd81e
to
dcd4cef
Compare
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 15, 2015
It's not clear what this means, because a macro in item position can expand to zero or more items. For now we disallow it, which is technically a
[breaking-change]
but is landing without an RFC. The `pub` keyword previously had no effect, which seems quite unintended.
Fixes rust-lang#18317.
Fixes rust-lang#14660.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear what this means, because a macro in item position can expand to zero or more items. For now we disallow it, which is technically a
but is landing without an RFC. The
pubkeyword previously had no effect, which seems quite unintended.Fixes #18317.
Fixes #14660.