-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename core_pattern_type
and core_pattern_types
lib feature gates to pattern_type_macro
#133863
Conversation
… to `pattern_type_macro` That's what the gates are actually gating, and the single char difference in naming was not helpful either
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
would you want to mark the original feature gates as removed, e.g. with a "renamed to In any case, r=me when CI is green. |
I guess #123646 will need updating? |
@bors r=lqd Yea we don't do that for lib features |
Rename `core_pattern_type` and `core_pattern_types` lib feature gates to `pattern_type_macro` That's what the gates are actually gating, and the single char difference in naming was not helpful either fixes rust-lang#128987
Rename `core_pattern_type` and `core_pattern_types` lib feature gates to `pattern_type_macro` That's what the gates are actually gating, and the single char difference in naming was not helpful either fixes rust-lang#128987
Rollup of 7 pull requests Successful merges: - rust-lang#118833 (Add lint against function pointer comparisons) - rust-lang#122161 (Fix suggestion when shorthand `self` has erroneous type) - rust-lang#133233 (Add context to "const in pattern" errors) - rust-lang#133843 (Do not emit empty suggestion) - rust-lang#133863 (Rename `core_pattern_type` and `core_pattern_types` lib feature gates to `pattern_type_macro`) - rust-lang#133872 (No need to create placeholders for GAT args in confirm_object_candidate) - rust-lang#133874 (`fn_sig_for_fn_abi` should return a `ty::FnSig`, no need for a binder) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 7 pull requests Successful merges: - rust-lang#118833 (Add lint against function pointer comparisons) - rust-lang#122161 (Fix suggestion when shorthand `self` has erroneous type) - rust-lang#133233 (Add context to "const in pattern" errors) - rust-lang#133843 (Do not emit empty suggestion) - rust-lang#133863 (Rename `core_pattern_type` and `core_pattern_types` lib feature gates to `pattern_type_macro`) - rust-lang#133872 (No need to create placeholders for GAT args in confirm_object_candidate) - rust-lang#133874 (`fn_sig_for_fn_abi` should return a `ty::FnSig`, no need for a binder) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 10 pull requests Successful merges: - rust-lang#118833 (Add lint against function pointer comparisons) - rust-lang#122161 (Fix suggestion when shorthand `self` has erroneous type) - rust-lang#133233 (Add context to "const in pattern" errors) - rust-lang#133761 (Update books) - rust-lang#133843 (Do not emit empty suggestion) - rust-lang#133863 (Rename `core_pattern_type` and `core_pattern_types` lib feature gates to `pattern_type_macro`) - rust-lang#133872 (No need to create placeholders for GAT args in confirm_object_candidate) - rust-lang#133874 (`fn_sig_for_fn_abi` should return a `ty::FnSig`, no need for a binder) - rust-lang#133890 (Add a new test ui/incoherent-inherent-impls/no-other-unrelated-errors to check E0116 does not cause unrelated errors) - rust-lang#133892 (Revert rust-lang#133817) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#133863 - oli-obk:push-pystoxvtvssx, r=lqd Rename `core_pattern_type` and `core_pattern_types` lib feature gates to `pattern_type_macro` That's what the gates are actually gating, and the single char difference in naming was not helpful either fixes rust-lang#128987
That's what the gates are actually gating, and the single char difference in naming was not helpful either
fixes #128987