Revert #133817 #133892
Merged
Revert #133817 #133892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ln, r=jieyouxu" This reverts commit 0585134, reversing changes made to 5530869. The PR unfortunately only converted the `ln!` instances, meaning that test output was messed up because stdout/stderr output interleaved when some `println!` instances were converted to `eprintln!` instances, while some `println!` instances remain unchanged.
rustbot
added
A-compiletest
|
This PR modifies If appropriate, please update |
bors
added
S-waiting-on-bors
|
I'll put this revert PR "into my size-7 rollup" by forming a size-8 one to avoid the queue becoming bigger & bigger, is that alright? |
Yes, sounds good |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2024
Rollup of 10 pull requests Successful merges: - rust-lang#118833 (Add lint against function pointer comparisons) - rust-lang#122161 (Fix suggestion when shorthand `self` has erroneous type) - rust-lang#133233 (Add context to "const in pattern" errors) - rust-lang#133761 (Update books) - rust-lang#133843 (Do not emit empty suggestion) - rust-lang#133863 (Rename `core_pattern_type` and `core_pattern_types` lib feature gates to `pattern_type_macro`) - rust-lang#133872 (No need to create placeholders for GAT args in confirm_object_candidate) - rust-lang#133874 (`fn_sig_for_fn_abi` should return a `ty::FnSig`, no need for a binder) - rust-lang#133890 (Add a new test ui/incoherent-inherent-impls/no-other-unrelated-errors to check E0116 does not cause unrelated errors) - rust-lang#133892 (Revert rust-lang#133817) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 5, 2024
Rollup merge of rust-lang#133892 - jieyouxu:revert-eprintln, r=jieyouxu Revert rust-lang#133817 This reverts commit 0585134, reversing changes made to 5530869. rust-lang#133817 unfortunately only converted the `println!` instances to `eprintln!`, meaning that some test output (via compiletest/bootstrap) was messed up because stdout/stderr output interleaved improperly when some `println!` instances were converted to `eprintln!` instances, while some `print!` instances remain unchanged. This made reading test output annoying for contributors cc rust-lang#133879. Closes rust-lang#133879 by reverting. rust-lang#133817 can be relanded in the future when `print!` instances are also matched with `println!` instances. cc `@clubby789` This is a clean revert so I'm going to self-approve this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0585134, reversing changes made to 5530869.
#133817 unfortunately only converted the
println!instances toeprintln!, meaning that some test output (via compiletest/bootstrap) was messed up because stdout/stderr output interleaved improperly when someprintln!instances were converted toeprintln!instances, while someprint!instances remain unchanged. This made reading test output annoying for contributors cc #133879.Closes #133879 by reverting.
#133817 can be relanded in the future when
print!instances are also matched withprintln!instances.cc @clubby789
This is a clean revert so I'm going to self-approve this PR.