Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new test ui/incoherent-inherent-impls/no-other-unrelated-errors to check E0116 does not cause unrelated errors #133890

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Add a new test ui/incoherent-inherent-impls/no-other-unrelated-errors to check E0116 does not cause unrelated errors #133890

merged 1 commit into from
Dec 5, 2024

Conversation

kei519
Copy link
Contributor

@kei519 kei519 commented Dec 5, 2024

rustc xxx (we do not know) to 1.82.0 emits unrelated errors when E0116 is present (see #125814).

We do not know what caused and fixed it, but add a test to confirm rustc does not cause the same error in the future.

@kei519
Add a new test ui/incoherent-inherent-impls/no-other-unrelated-errors…
892d585 
… to check E0116 does not cause unrelated errors

rustc xxx (we do not know) to 1.82.0 emits unrelated errors when E0116
is present (see rust-lang#125814).

We do not know what caused and fixed it, but add a test to confirm rustc
does not cause the same error in the future.
@rustbot
Copy link
Collaborator

rustbot commented Dec 5, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @wesleywiser (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 5, 2024
@compiler-errors
Copy link
Member

For the record, this was fixed in #130764. I don't think it's totally necessary to add a new test, but I guess it doesn't hurt.

We do not know what caused and fixed it [...]

For future reference, it should be pretty easy to use cargo-bisect-rustc to figure out what commit changes behavior in rustc.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 5, 2024

📌 Commit 892d585 has been approved by compiler-errors

It is now in the queue for this repository.

@compiler-errors compiler-errors self-assigned this Dec 5, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 5, 2024
@fmease fmease mentioned this pull request Dec 5, 2024
Merged
@kei519
Copy link
Contributor Author

kei519 commented Dec 5, 2024 •
edited
Loading

Thank you for tell me about cargo-rustc-bisect. I'll use it next time.

Should I change the commit message to indicate what commit causes and fixes it?
(I forgot that this commit is already approved)

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2024
@bors
Auto merge of rust-lang#133893 - fmease:rollup-11pi6fg, r=fmease
0e98766 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#118833 (Add lint against function pointer comparisons)
 - rust-lang#122161 (Fix suggestion when shorthand `self` has erroneous type)
 - rust-lang#133233 (Add context to "const in pattern" errors)
 - rust-lang#133761 (Update books)
 - rust-lang#133843 (Do not emit empty suggestion)
 - rust-lang#133863 (Rename `core_pattern_type` and `core_pattern_types` lib feature  gates to `pattern_type_macro`)
 - rust-lang#133872 (No need to create placeholders for GAT args in confirm_object_candidate)
 - rust-lang#133874 (`fn_sig_for_fn_abi` should return a `ty::FnSig`, no need for a binder)
 - rust-lang#133890 (Add a new test ui/incoherent-inherent-impls/no-other-unrelated-errors to check E0116 does not cause unrelated errors)
 - rust-lang#133892 (Revert rust-lang#133817)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 37c6b55 into rust-lang:master Dec 5, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2024
@rust-timer
Unrolled build for rust-lang#133890
a26253e 
Rollup merge of rust-lang#133890 - kei519:fix-125814, r=compiler-errors

Add a new test ui/incoherent-inherent-impls/no-other-unrelated-errors to check E0116 does not cause unrelated errors

rustc xxx (we do not know) to 1.82.0 emits unrelated errors when E0116 is present (see rust-lang#125814).

We do not know what caused and fixed it, but add a test to confirm rustc does not cause the same error in the future.
@kei519 kei519 deleted the fix-125814 branch December 5, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kei519 @rustbot @compiler-errors @bors @wesleywiser