Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #120660

Merged
merged 115 commits into from
Feb 5, 2024
Merged

Rollup of 9 pull requests #120660

merged 115 commits into from
Feb 5, 2024

Commits on Dec 31, 2023

  1. Configuration menu
    Copy the full SHA
    7ac4515 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Configuration menu
    Copy the full SHA
    16e117c View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Configuration menu
    Copy the full SHA
    e15f40e View commit details
    Browse the repository at this point in the history
  2. fix lint and fmt

    Young-Flash committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    56f54c8 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Fix copy/paste error.

    The `CString` handling code is erroneously identical to the `ByteString`
    handling code.
    nnethercote committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    85d56ee View commit details
    Browse the repository at this point in the history
  2. Rework CStrUnit.

    - Rename it as `MixedUnit`, because it will soon be used in more than
      just C string literals.
    - Change the `Byte` variant to `HighByte` and use it only for
      `\x80`..`\xff` cases. This fixes the old inexactness where ASCII chars
      could be encoded with either `Byte` or `Char`.
    - Add useful comments.
    - Remove `is_ascii`, in favour of `u8::is_ascii`.
    nnethercote committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    5651407 View commit details
    Browse the repository at this point in the history
  3. Rename the unescaping functions.

    `unescape_literal` becomes `unescape_unicode`, and `unescape_c_string`
    becomes `unescape_mixed`. Because rfc3349 will mean that C string
    literals will no longer be the only mixed utf8 literals.
    nnethercote committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    858f4ac View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Configuration menu
    Copy the full SHA
    96ebad0 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Configuration menu
    Copy the full SHA
    da798bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    57934ac View commit details
    Browse the repository at this point in the history
  3. Make return a snippet

    Alainx277 committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    51d57b9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7ec32d0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b22e772 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Configuration menu
    Copy the full SHA
    8fab92f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81d713e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a8a18f3 View commit details
    Browse the repository at this point in the history
  4. merge imports assist always applies to covering use item except for n…

    …ested use tree selections
    davidsemakula committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    b241593 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fc00602 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    84e1314 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6f303f4 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1bd21e9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f43cea0 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6aec11a View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Configuration menu
    Copy the full SHA
    6181102 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b71aca View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#15730 - Alainx277:let-else-postfix, r=Veykril

    Add postfix completion for let else
    
    Adds a postfix completion for let else syntax, similar to the if let postfix.
    bors committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    d13951f View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Bump scip

    lnicola committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    20c0167 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5860763 View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#16439 - wasd96040501:feat/gotodef3, r=Veykril

    feat: Support for GOTO def from *inside* files included with include! macro
    
    close rust-lang#14937
    Try to implement goto def from *inside* files included with include! macro.
    This implementation has two limitations:
    1. Only **one** file which calls include! will be tracked. (I think multiple file be included is a rare case and we may let it go for now)
    2. Mapping token from included file to macro call file (semantics.rs:646~658) works fine but I am not sure is this the correct way to implement.
    bors committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    22b6f96 View commit details
    Browse the repository at this point in the history
  4. Auto merge of rust-lang#16447 - Veykril:mir-errors, r=Veykril

    intenral: Cleanup error variants in MIR code a bit
    bors committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    11b401d View commit details
    Browse the repository at this point in the history
  5. minor: update warning msg

    Young-Flash committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4facb62 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dba3fc4 View commit details
    Browse the repository at this point in the history
  7. minor: correct typos

    Young-Flash committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    db9fd37 View commit details
    Browse the repository at this point in the history
  8. collapsible_if

    Urhengulas committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    75a42f1 View commit details
    Browse the repository at this point in the history
  9. CI: add clippy

    Urhengulas committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    73c7c72 View commit details
    Browse the repository at this point in the history
  10. CI: Don't deny clippy warnings

    We configure that in the lint table in `Cargo.toml`.
    Urhengulas committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    628f701 View commit details
    Browse the repository at this point in the history
  11. cargo clippy --fix

    Urhengulas committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    43b1ae0 View commit details
    Browse the repository at this point in the history
  12. Auto merge of rust-lang#16413 - Urhengulas:clippy-ci, r=Veykril

    internal: Add `clippy` to CI
    
    Follow-up to rust-lang#16401
    bors committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    da4d5f8 View commit details
    Browse the repository at this point in the history
  13. Auto merge of rust-lang#16417 - davidsemakula:normalize-use-trees, r=…

    …Veykril
    
    feat: "Normalize import" assist and utilities for normalizing use trees
    
    - Add import/use tree normalization utilities
    - Add "normalize import" assist
    - Update "merge imports" assist to always apply to the covering use item except for nested use tree selections
    - Update "merge imports" assist to avoid adding unnecessary braces when merging nested use tree selections
    
    See [this discussion](rust-lang/rust-analyzer#16372 (comment)) for the motivation for the new "normalize import" assist and changes to the "merge imports" assist.
    bors committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    63123ab View commit details
    Browse the repository at this point in the history
  14. internal: switch to tracing from log

    This commit also adds `tracing` to NotificationDispatcher/RequestDispatcher,
    bumps `rust-analyzer-salsa` to 0.17.0-pre.6, `always-assert` to 0.2, and
    removes the homegrown `hprof` implementation in favor of a vendored
    tracing-span-tree.
    davidbarsky committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e1ea7c8 View commit details
    Browse the repository at this point in the history
  15. Auto merge of rust-lang#16394 - davidbarsky:david/add-more-tracing-sp…

    …ans, r=Veykril
    
    internal: add some `tracing` to {Request, Notification}Dispatch
    
    Some of the tracing config would need to be changed in order to benefit more from this (especially `.with_span_events(FmtSpan::CLOSE)`), which provides span events like the following:
    
    ```
    2024-01-18T02:41:06.675779Z  INFO request{method="textDocument/codeLens" request_id=RequestId(I32(17))}: rust_analyzer::dispatch: close time.busy=61.8µs time.idle=5.29µs
    ```
    
    I dunno if y'all need `LoggerFormatter` in here, but if you don't, I'd be happy to yeet it out of rust-analyzer. In any case, this provided a pretty decent amount of information in the logs, and I can expand this as needed or we can land this PR and expand later.
    bors committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    d923d62 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    17d2e8d View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    8f1a253 View commit details
    Browse the repository at this point in the history
  18. Auto merge of rust-lang#16453 - Veykril:brackets, r=Veykril

    internal: Undo special bracket classification for attributes in vscode config
    
    I changed this thinking the `#` could be considered part of the bracket but on second though I don't think that's quite right in general.
    
    Fixes rust-lang/rust-analyzer#16449
    bors committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9a832c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Auto merge of rust-lang#16441 - Young-Flash:exclude_tests_refs, r=Vey…

    …kril
    
    feat: enable excluding refs search results in test
    
    ## Change
    
    Here I introduce a new `ReferenceCategory::Test` type to indicate whether the function where this reference is located is marked as `#[test]`, and expose an config item (`rust-analyzer.references.excludeTests`) to client.
    
    I also changed the signature of `ReferenceCategory::new`, adding a `sema: &Semantics<'_, RootDatabase>` param to do some hir analysis. Hope the current implementation is good to go.
    
    ## Demo
    
    `"rust-analyzer.references.excludeTests": false`
    
    ![include](https://github.com/rust-lang/rust-analyzer/assets/71162630/9f1176d4-7b41-4f49-ac79-55d25a42d5d1)
    
    `"rust-analyzer.references.excludeTests": true`
    
    ![exclude](https://github.com/rust-lang/rust-analyzer/assets/71162630/2938b44b-9e5b-48de-a049-453f5bbc09d0)
    
    close rust-lang/rust-analyzer#14530
    bors committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e4146af View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    604479c View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#16459 - Veykril:diagnostics, r=Veykril

    internal: Use improved adjusted_display_range for all diagnostics
    bors committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e48bc04 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d252247 View commit details
    Browse the repository at this point in the history
  5. Auto merge of rust-lang#16461 - Veykril:expansion-info, r=Veykril

    internal: Remove unnecessary usages of ExpansionInfo
    
    And some follow up simplifications to rust-lang/rust-analyzer#16439
    bors committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    2661c27 View commit details
    Browse the repository at this point in the history
  6. Auto merge of rust-lang#16445 - lnicola:bump-scip, r=lnicola

    internal: Bump scip
    
    Fixes rust-lang#16440
    bors committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    9d837a6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    62ff8f3 View commit details
    Browse the repository at this point in the history
  8. Auto merge of rust-lang#16448 - Young-Flash:typos, r=lnicola

    minor: correct typos
    
    I use [crate-ci/typos](https://github.com/crate-ci/typos) to check typos in codebase, if it's ok with you, I'd like to add a typo check CI using [typos](https://github.com/crate-ci/typos) (with Apache-2.0, MIT licenses).
    
    BTW, we can add a [_typos.toml](https://github.com/crate-ci/typos/blob/master/docs/reference.md) as white list for some intentional typos
    bors committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    355c944 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    251b14f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    579e98c View commit details
    Browse the repository at this point in the history
  11. skip_while_next

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    386d438 View commit details
    Browse the repository at this point in the history
  12. toplevel_ref_arg

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    daa2072 View commit details
    Browse the repository at this point in the history
  13. unnecessary_cast

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    de6f956 View commit details
    Browse the repository at this point in the history
  14. unnecessary_filter_map

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    f15ee8a View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c4302ea View commit details
    Browse the repository at this point in the history
  16. Refactor

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    f191b80 View commit details
    Browse the repository at this point in the history
  17. unnecessary_mut_passed

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e7d0dea View commit details
    Browse the repository at this point in the history
  18. useless_conversion

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b73ee2f View commit details
    Browse the repository at this point in the history
  19. useless_format

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b176cf2 View commit details
    Browse the repository at this point in the history
  20. wildcard_in_or_patterns

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    0adb4d1 View commit details
    Browse the repository at this point in the history
  21. derivable_impls

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    c468834 View commit details
    Browse the repository at this point in the history
  22. borrow_deref_ref

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    dd9f27b View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    04ccef8 View commit details
    Browse the repository at this point in the history
  24. large_enum_variant

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e7e09e7 View commit details
    Browse the repository at this point in the history
  25. new_without_default

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    d37f4e0 View commit details
    Browse the repository at this point in the history
  26. format_collect

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    771c6c9 View commit details
    Browse the repository at this point in the history
  27. cargo clippy --fix

    Urhengulas committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    df2c7a6 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    44494e2 View commit details
    Browse the repository at this point in the history
  29. Auto merge of rust-lang#16456 - davidbarsky:david/tracing-followups, …

    …r=Veykril
    
    internal: `tracing` improvements and followups
    
    Hi folks! Building on rust-lang/rust-analyzer#16394, I've got a few small tweaks:
    - Removed the accidental `mod.rs` usage that I introduced.
    - Removed a panic in `pat_analysis.rs`.
    - Recorded the event kind in `handle_event` to better distinguish what _kind_ of event is being handled.
    - Did a small refactor of `hprof` to have somewhat more linear control flow, and more importantly, write the recorded fields to the output.
    
    The end result is the following:
    <img width="1530" alt="A screenshot of Visual Studio Code on a Mac. `hprof.rs` is open, with " src="https://github.com/rust-lang/rust-analyzer/assets/2067774/bd11dde5-b2da-4774-bc38-bcb4772d1192">
    bors committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    0396811 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    a1fdb87 View commit details
    Browse the repository at this point in the history
  31. Auto merge of rust-lang#16463 - clubby789:remove-abi_amdgpu_kernel, r…

    …=lnicola
    
    internal: Remove `abi_amdgpu_kernel` references
    
    This feature was removed in rust-lang#120495
    bors committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    1ab1a25 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    23f4b7f View commit details
    Browse the repository at this point in the history
  33. Auto merge of rust-lang#16465 - Veykril:eprintln, r=Veykril

    minor: Remove `stdx::eprintln` overwrite
    bors committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    42cb1a2 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Configuration menu
    Copy the full SHA
    671c776 View commit details
    Browse the repository at this point in the history
  2. Auto merge of rust-lang#16468 - ThomasFrans:docs-update-plugin-url, r…

    …=lnicola
    
    minor: Recommend maintained Neovim plugin in documentation
    bors committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3afa6b1 View commit details
    Browse the repository at this point in the history
  3. Auto merge of rust-lang#16416 - Young-Flash:cargo_ext_detect, r=lnicola

    internal: VS Code: report conflict with `panicbit.cargo`
    
    <img width="359" alt="notification" src="https://github.com/rust-lang/rust-analyzer/assets/71162630/420b9f34-ba73-4436-b868-6cd87c62287d">
    
    related to rust-lang/rust-analyzer#16392
    bors committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    135a8d9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    36cb518 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b0be296 View commit details
    Browse the repository at this point in the history
  6. Auto merge of rust-lang#16451 - Urhengulas:satisfy-clippy, r=Veykril

    internal: Work through temporarily allowed clippy lints, part 2
    
    Another follow-up to rust-lang/rust-analyzer#16401.
    bors committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    850ba2f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Update libc to 0.2.153

    pheki committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    ee87033 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ba31cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4f09335 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ef07b05 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7a0b887 View commit details
    Browse the repository at this point in the history
  6. Auto merge of rust-lang#16476 - lnicola:sync-from-rust, r=lnicola

    internal: sync from downstream
    bors committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    980d348 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ba2910a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    70d6141 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a52a4d9 View commit details
    Browse the repository at this point in the history
  10. Auto merge of rust-lang#16469 - Young-Flash:ci_typos, r=lnicola

    internal: add typos check CI (part 2)
    
    follow up rust-lang/rust-analyzer#16448
    bors committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    8f6a728 View commit details
    Browse the repository at this point in the history
  11. miri: normalize struct tail in ABI compat check

    Lukas Markeffsky committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    30e7b87 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2024

  1. Configuration menu
    Copy the full SHA
    a27e45a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c694db View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a605b96 View commit details
    Browse the repository at this point in the history
  4. Auto merge of rust-lang#16479 - lnicola:macos-12, r=lnicola

    internal: Bump release runners to MacOS 12
    bors committed Feb 3, 2024
    Configuration menu
    Copy the full SHA
    0113bc9 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Configuration menu
    Copy the full SHA
    468f400 View commit details
    Browse the repository at this point in the history
  2. Try to fix in-tree build

    lnicola committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    98ad126 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cb4e69a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fe420dc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8dd2b37 View commit details
    Browse the repository at this point in the history
  6. coverage: Make unexpansion of closure bodies more precise

    This improves the coverage instrumentation of closures declared in macros, as
    seen in `closure_macro.rs` and `closure_macro_async.rs`.
    Zalathar committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    dd6d7f2 View commit details
    Browse the repository at this point in the history
  7. coverage: Hoist special handling of async function spans

    This sidesteps the normal span refinement code in cases where we know that we
    are only dealing with the special signature span that represents having called
    an async function.
    Zalathar committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    fde1702 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a246b6b View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Rollup merge of rust-lang#119481 - romanows:fix-doc-select-nth-unstab…

    …le, r=Mark-Simulacrum
    
    Clarify ambiguity in select_nth_unstable docs
    
    Original docs for `select_nth_unstable` family of functions were ambiguous as to whether "the element at `index`" was the element at `index` before the function reordered the elements or after the function reordered the elements.
    
    The most helpful change in this PR is to change the given examples to make this absolutely clear.  Before, "the element at `index`" was the same value before and after the reordering, so it didn't help disambiguate the meaning.  I've changed the example for `select_nth_unstable` and `select_nth_unstable_by` so that "the element at `index`" is different before and after the reordering, which clears up the ambiguity.  The function `select_nth_unstable_by_key` already had an example that was unambiguous.
    
    In an attempt to clear up the ambiguity from the get-go, I've added a bit of redundancy to the text.  Now the docs refer to "the element at `index` *after the reordering*".
    matthiaskrgr authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    7158b3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca36ed2 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#120458 - rytheo:cstr-conversion-doc, r=Mark…

    …-Simulacrum
    
    Document `&CStr` to `CString` conversion
    
    Related to rust-lang#51430
    matthiaskrgr authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    9838e94 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#120569 - Zalathar:fn-sig, r=oli-obk

    coverage: Improve handling of function/closure spans
    
    This is a combination of some loosely-related changes that touch the same code:
    
    1. Make unexpansion of closure bodies more precise, by unexpanding back to the context of the closure declaration, instead of unexpanding all the way back to the top-level context. This preserves the way we handle async desugaring and closures containing a single bang-macro, while also giving better results for closures defined in macros.
    2. Skip the normal span-refinement code when dealing with the trivial outer part of an async function.
    3. Be more explicit about the fact that `fn_sig_span` has been extended to the start of the function body, and is not necessarily present.
    
    ---
    
    `@rustbot` label +A-code-coverage
    matthiaskrgr authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    7294c15 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#120572 - pheki:update-libc, r=Mark-Simulacrum

    Update libc to 0.2.153
    
    Bumps libc dependency to 0.2.153, which includes this fix, required for building std for the vita: rust-lang/libc#3552
    matthiaskrgr authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    16200db View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#120587 - lukas-code:miri-tail-normalize, r=…

    …RalfJung
    
    miri: normalize struct tail in ABI compat check
    
    fixes rust-lang/miri#3282
    extracted from rust-lang#120354, see rust-lang#120354 (comment) for context
    
    r? ```@RalfJung```
    matthiaskrgr authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    e348f07 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#120607 - conradludgate:fix-120603, r=dtolnay

    fix rust-lang#120603 by adding a check in default_read_buf
    
    Fixes rust-lang#120603 by checking the returned read n is in-bounds of the cursor.
    
    Interestingly, I noticed that `BorrowedBuf` side-steps this issue by using checked accesses. Maybe this can be switched to unchecked to mirror what BufReader does https://github.com/rust-lang/rust/blob/bf3c6c5bed498f41ad815641319a1ad9bcecb8e8/library/core/src/io/borrowed_buf.rs#L95
    matthiaskrgr authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    d8e9ddc View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#120636 - lnicola:sync-from-ra, r=lnicola

    Subtree update of `rust-analyzer`
    
    r? ghost
    matthiaskrgr authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    bc98f57 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#120641 - klensy:copypaste-me, r=notriddle

    rustdoc: trait.impl, type.impl: sort impls to make it not depend on serialization order
    
    Can be tested by running `cargo doc` with different rust versions on some crate and comparing `doc` folders: files in `trait.impl` and `type.impl` will sometimes have different order of impls.
    matthiaskrgr authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    a2d3eed View commit details
    Browse the repository at this point in the history