libsyntax: Accept use foo as bar; in lieu of use bar = foo;
#16468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5275,6 +5275,7 @@ impl<'a> Parser<'a> { | |||
| match self.token { | |||
| token::EQ => { | |||
| // x = foo::bar | |||
| // NOTE(pcwalton, #16461): Remove after snapshot. | |||
There was a problem hiding this comment.
Could we retain the parsing but emit a warning for awhile instead of removing this entirely after a snapshot lands? I'd just think the comment should be rephrased to say something like "make this a warning after a snapshot".
Also, could you make sure that the string "stage0" shows up here? (useful for grepping)
|
🌴 Thanks @pcwalton! |
|
Ah, and one other thing, could this update the EBNF in the manual as well? |
pcwalton
changed the title
use foo as bar; in lieu of use bar as foo;use foo as bar; in lieu of use bar = foo;
The old syntax will be removed after a snapshot. RFC rust-lang#47. Issue rust-lang#16461.
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 5, 2024
…=lnicola minor: Recommend maintained Neovim plugin in documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old syntax will be removed after a snapshot.
RFC #47.
Issue #16461.
r? @brson