Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated references to librustc_middle #119600

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Remove outdated references to librustc_middle #119600

merged 1 commit into from
Feb 5, 2024

Conversation

aDotInTheVoid
Copy link
Member

The relevant comment is now in

rust/compiler/rustc_middle/src/tests.rs

Lines 3 to 13 in 791a53f

// FIXME(#27438): right now the unit tests of librustc_middle don't refer to any actual
// functions generated in librustc_data_structures (all
// references are through generic functions), but statics are
// referenced from time to time. Due to this bug we won't
// actually correctly link in the statics unless we also
// reference a function, so be sure to reference a dummy
// function.
#[test]
fn noop() {
rustc_data_structures::__noop_fix_for_27438();
}

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2024

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 5, 2024
@aDotInTheVoid aDotInTheVoid added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Jan 5, 2024
@compiler-errors
Copy link
Member

Can you fix the other 6 instances of librustc_middle in the codebase? Otherwise I don't see much purpose in putting up a PR that fixes just one.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2024
@aDotInTheVoid aDotInTheVoid changed the title Fix outdated path in comment. Remove outdated references to librustc_middle Jan 5, 2024
@aDotInTheVoid
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2024
@fmease
Copy link
Member

fmease commented Feb 4, 2024

r? compiler

@rustbot rustbot assigned petrochenkov and unassigned b-naber Feb 4, 2024
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 4, 2024

📌 Commit 16e117c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 5, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 5, 2024
@bors
Auto merge of rust-lang#120660 - matthiaskrgr:rollup-zuqljul, r=matth…
8c0b4f6 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#119481 (Clarify ambiguity in select_nth_unstable docs)
 - rust-lang#119600 (Remove outdated references to librustc_middle)
 - rust-lang#120458 (Document `&CStr` to `CString` conversion)
 - rust-lang#120569 (coverage: Improve handling of function/closure spans)
 - rust-lang#120572 (Update libc to 0.2.153)
 - rust-lang#120587 (miri: normalize struct tail in ABI compat check)
 - rust-lang#120607 (fix rust-lang#120603 by adding a check in default_read_buf)
 - rust-lang#120636 (Subtree update of `rust-analyzer`)
 - rust-lang#120641 (rustdoc: trait.impl, type.impl: sort impls to make it not depend on serialization order)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ca36ed2 into rust-lang:master Feb 5, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 5, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 5, 2024
@rust-timer
Unrolled build for rust-lang#119600
934d394 
Rollup merge of rust-lang#119600 - aDotInTheVoid:comment-fix, r=compiler-errors

Remove outdated references to librustc_middle

The relevant comment is now in https://github.com/rust-lang/rust/blob/791a53f380d5cf800191f25941c94ace5099876e/compiler/rustc_middle/src/tests.rs#L3-L13
@aDotInTheVoid aDotInTheVoid deleted the comment-fix branch February 5, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
7 participants
@aDotInTheVoid @rustbot @compiler-errors @fmease @bors @petrochenkov @b-naber