Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #102331

Merged
merged 14 commits into from
Sep 27, 2022
Merged

Rollup of 6 pull requests #102331

merged 14 commits into from
Sep 27, 2022

Conversation

notriddle
Copy link
Contributor

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GuillaumeGomez and others added 14 commits September 26, 2022 12:37
This was added in 5101078, to fix
the display of the module items and search results tables (see the discussion
in rust-lang#86725).

Those aren't tables any more. The only remaining table is in docblock, which
has its own padding declarations.
This was added in 5101078, to fix the
display of the module items and search results tables (see the discussion in
rust-lang#86725).

Those aren't tables any more. The only remaining table is in docblock, which
needs this attribute to look right.
…-unwrap-or-default, r=thomcc

Improve code example for Option::unwrap_or_default

Fixes rust-lang#100054.
Follow-up of rust-lang#102259.

r? ``@thomcc``
…aumeGomez

rustdoc: merge CSS `table` rules into `.docblock`

This was added in 5101078, to fix the display of the module items and search results tables (see the discussion in rust-lang#86725).

Those aren't tables any more. The only remaining table is in docblock, which has its own padding declarations.
…illaumeGomez

 Rustdoc-Json: List impls for primitives

 Closes rust-lang#101695

 Partially addresses rust-lang#100961

r? ``@GuillaumeGomez``
Document that Display automatically implements ToString

Closes rust-lang#92941

r? rust-lang/docs
…=GuillaumeGomez

rustdoc: give `.line-number` / `.line-numbers` meaningful names
… r=thomcc

rustdoc: Update doc comment for splitn_mut to include mutable in the …

The doc comment for [splitn](https://github.com/rust-lang/rust/blob/master/library/core/src/slice/mod.rs#L2051:L2056) is the exact same as the comment for [splitn_mut](https://github.com/rust-lang/rust/blob/master/library/core/src/slice/mod.rs#L2079:L2084).  The doc comment for `splitn_mut` should instead say it's working on a mutable subslice.
@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 26, 2022
@notriddle
Copy link
Contributor Author

@bors r+ p=6

@bors
Copy link
Contributor

bors commented Sep 26, 2022

📌 Commit 7381d7d has been approved by notriddle

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 26, 2022
@bors
Copy link
Contributor

bors commented Sep 27, 2022

⌛ Testing commit 7381d7d with merge cd4d9d9...

@bors
Copy link
Contributor

bors commented Sep 27, 2022

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing cd4d9d9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 27, 2022
@bors bors merged commit cd4d9d9 into rust-lang:master Sep 27, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 27, 2022
@notriddle notriddle deleted the rollup-dmefd2d branch September 27, 2022 04:39
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cd4d9d9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.0% [-3.9%, -2.0%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.1% [5.6%, 6.6%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.4% [-4.6%, -2.7%] 3
All ❌✅ (primary) - - 0

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants