rustdoc: merge CSS table rules into .docblock
#102319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added in 5101078, to fix the display of the module items and search results tables (see the discussion in rust-lang#86725). Those aren't tables any more. The only remaining table is in docblock, which has its own padding declarations.
rustbot
added
the
T-rustdoc
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon. Please see the contribution instructions for more information. |
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
rust-highfive
added
the
S-waiting-on-review
This was added in 5101078, to fix the display of the module items and search results tables (see the discussion in rust-lang#86725). Those aren't tables any more. The only remaining table is in docblock, which needs this attribute to look right.
notriddle
changed the title
td, th { padding 0 }table rules into .docblock
| @@ -299,15 +299,6 @@ summary { | |||
|
|
|||
| /* Fix some style changes due to normalize.css 8 */ | |||
|
|
|||
| td, | |||
| th { | |||
| padding: 0; | |||
There was a problem hiding this comment.
I wonder if we relied on it for tables in docblock too? Well, that would be surprising to need it for tables in the first place.
GuillaumeGomez
approved these changes
Sep 26, 2022
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Sep 26, 2022
…aumeGomez rustdoc: merge CSS `table` rules into `.docblock` This was added in 5101078, to fix the display of the module items and search results tables (see the discussion in rust-lang#86725). Those aren't tables any more. The only remaining table is in docblock, which has its own padding declarations.
This was referenced Sep 26, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#102283 (Improve code example for Option::unwrap_or_default) - rust-lang#102319 (rustdoc: merge CSS `table` rules into `.docblock`) - rust-lang#102321 ( Rustdoc-Json: List impls for primitives) - rust-lang#102322 (Document that Display automatically implements ToString) - rust-lang#102325 (rustdoc: give `.line-number` / `.line-numbers` meaningful names) - rust-lang#102326 (rustdoc: Update doc comment for splitn_mut to include mutable in the …) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in 5101078, to fix the display of the module items and search results tables (see the discussion in #86725).
Those aren't tables any more. The only remaining table is in docblock, which has its own padding declarations.