Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc-Json: List impls for primitives #101695

Closed
aDotInTheVoid opened this issue Sep 11, 2022 · 0 comments · Fixed by #102321
Closed

Rustdoc-Json: List impls for primitives #101695

aDotInTheVoid opened this issue Sep 11, 2022 · 0 comments · Fixed by #102321
Labels
A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@aDotInTheVoid
Copy link
Member

#![feature(no_core)]
#![feature(rustdoc_internals)]
#![no_core]

pub trait Local {}

impl Local for bool {}

#[doc(primitive = "bool")]
/// Boolean docs
mod prim_bool {}

Gives

"0:3:366": {
      "attrs": ["#[doc(primitive = \"bool\")]"],
      "crate_id": 0,
      "deprecation": null,
      "docs": "Boolean docs",
      "id": "0:3:366",
      "inner": "bool",
      "kind": "primitive_type",
      "links": {},
      "name": "bool",
      "span": {
        "begin": [12, 0],
        "end": [12, 16],
        "filename": "/data/ne321/rust/src/test/rustdoc-json/impls/local_for_local_primitive.rs"
      },
      "visibility": "public"
    }

but doesn't show the trait impls for bool.

@rustbot modify labels: +A-rustdoc-json +T-rustdoc

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 11, 2022
notriddle added a commit to notriddle/rust that referenced this issue Sep 26, 2022
…illaumeGomez

 Rustdoc-Json: List impls for primitives

 Closes rust-lang#101695

 Partially addresses rust-lang#100961

r? `@GuillaumeGomez`
notriddle added a commit to notriddle/rust that referenced this issue Sep 26, 2022
…illaumeGomez

 Rustdoc-Json: List impls for primitives

 Closes rust-lang#101695

 Partially addresses rust-lang#100961

r? ``@GuillaumeGomez``
@bors bors closed this as completed in aac7429 Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants