Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.30.1 point release tracking issue #55594

Closed
pietroalbini opened this issue Nov 1, 2018 · 9 comments
Closed

1.30.1 point release tracking issue #55594

pietroalbini opened this issue Nov 1, 2018 · 9 comments
Labels
T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@pietroalbini
Copy link
Member

pietroalbini commented Nov 1, 2018 •
edited
Loading

This issue tracks the 1.30.1 point release, which is scheduled to be released on Thursday 8th.

PRs that are going to be included in the point release:

cc @rust-lang/release
@pietroalbini pietroalbini added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Nov 1, 2018
@Eh2406
Copy link
Contributor

Eh2406 commented Nov 1, 2018

If it is not hard to do, I'd be ok including rust-lang/cargo#6122.

@ehuss
Copy link
Contributor

ehuss commented Nov 2, 2018

I'm happy to prepare the PRs for the cargo issue, but I don't know how the decision gets made as to whether or not it should be included.

@pietroalbini
Copy link
Member Author

@ehuss @Eh2406 the cargo team should decide if the fix is safe to be backported.

@pietroalbini
Copy link
Member Author

The rustdoc fix is not fully done: #54524 is still a stable-to-stable regression. If we can fix that soon we should hold off making the point release, to avoid doing a second one.

@alexcrichton
Copy link
Member

@ehuss I think it's definitely safe to backport that to stable, so if you'd like feel free to prepare the stable branch for Cargo!

@ehuss ehuss mentioned this issue Nov 3, 2018
Closed
@joelgallant
Copy link
Contributor

Is #55590 going to be included? @pietroalbini

@pietroalbini
Copy link
Member Author

Yep.

@jonas-schievink
Copy link
Contributor

Should this also include #55717 to fix #54524?

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Nov 7, 2018
Merged
bors added a commit that referenced this issue Nov 7, 2018
@bors
Auto merge of #55738 - Mark-Simulacrum:stable-next, r=Mark-Simulacrum
1433507 
1.30.1 stable release

I believe this includes all of the relevant pieces from #55594. Backports all proceeded smoothly.

cc @rust-lang/release
@pietroalbini
Copy link
Member Author

@jonas-schievink yep, that PR has been included.

@nastevens nastevens mentioned this issue Nov 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ehuss @alexcrichton @joelgallant @jonas-schievink @pietroalbini @Eh2406 @Mark-Simulacrum