-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix link to macros chapter #55325
Merged
Merged
Fix link to macros chapter #55325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're gonna link to nightly as this didn't make it into the corresponding stable.
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 24, 2018
Hm, the link points to stable? |
frewsxcv
reviewed
Oct 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with the stable
→ nightly
adjustment
Co-Authored-By: steveklabnik <[email protected]>
dangit, I must have made an error, sorry about that! anyway applied |
@bors r=frewsxcv rollup |
📌 Commit ee26e8e has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 25, 2018
Closed
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Oct 25, 2018
…rewsxcv Fix link to macros chapter We're gonna link to nightly as this didn't make it into the corresponding stable. r? @Mark-Simulacrum @Centril
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 26, 2018
…rewsxcv Fix link to macros chapter We're gonna link to nightly as this didn't make it into the corresponding stable. r? @Mark-Simulacrum @Centril
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 26, 2018
…rewsxcv Fix link to macros chapter We're gonna link to nightly as this didn't make it into the corresponding stable. r? @Mark-Simulacrum @Centril
bors
added a commit
that referenced
this pull request
Oct 26, 2018
Rollup of 21 pull requests Successful merges: - #54816 (Don't try to promote already promoted out temporaries) - #54824 (Cleanup rustdoc tests with `@!has` and `@!matches`) - #54921 (Add line numbers option to rustdoc) - #55167 (Add a "cheap" mode for `compute_missing_ctors`.) - #55258 (Fix Rustdoc ICE when checking blanket impls) - #55264 (Compile the libstd we distribute with -Ccodegen-unit=1) - #55271 (Unimplement ExactSizeIterator for MIR traversing iterators) - #55292 (Macro diagnostics tweaks) - #55298 (Point at macro definition when no rules expect token) - #55301 (List allowed tokens after macro fragments) - #55302 (Extend the impl_stable_hash_for! macro for miri.) - #55325 (Fix link to macros chapter) - #55343 (rustbuild: fix remap-debuginfo when building a release) - #55346 (Shrink `Statement`.) - #55358 (Remove redundant clone (2)) - #55370 (Update mailmap for estebank) - #55375 (Typo fixes in configure_cmake comments) - #55378 (rustbuild: use configured linker to build boostrap) - #55379 (validity: assert that unions are non-empty) - #55383 (Use `SmallVec` for the queue in `coerce_unsized`.) - #55391 (bootstrap: clean up a few clippy findings)
bors
added a commit
that referenced
this pull request
Oct 29, 2018
[beta]: Prepare the 1.31.0 beta release * Update to Cargo's branched 1.31.0 branch * Update the channel to `beta` Rolled up beta-accepted PRs: * #55362: Remove `cargo new --edition` from release notes. * #55325: Fix link to macros chapter * #55358: Remove redundant clone (2) * #55346: Shrink `Statement`. * #55274: Handle bindings in substructure of patterns with type ascriptions * #55297: Partial implementation of uniform paths 2.0 to land before beta * #55192: Fix ordering of nested modules in non-mod.rs mods * #55185: path suggestions in Rust 2018 should point out the change in semantics * #55423: back out bogus `Ok`-wrapping suggestion on `?` arm type mismatch Note that **this does not update the bootstrap compiler** due to #55404
pietroalbini
added
stable-nominated
Nominated for backporting to the compiler in the stable channel.
stable-accepted
Accepted for backporting to the compiler in the stable channel.
labels
Nov 1, 2018
pietroalbini
added
stable-accepted
Accepted for backporting to the compiler in the stable channel.
and removed
stable-accepted
Accepted for backporting to the compiler in the stable channel.
stable-nominated
Nominated for backporting to the compiler in the stable channel.
labels
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
stable-accepted
Accepted for backporting to the compiler in the stable channel.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're gonna link to nightly as this didn't make it into the corresponding stable.
r? @Mark-Simulacrum @Centril