Backport fix for rustdoc overflows

[nikomatsakis]

Backport of #54199 to stable

Fixes #52873

[rust-highfive]

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

[rust-highfive]

⚠️ Warning ⚠️

• Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

[nikomatsakis]

@bors r=eddyb

This was a clean backport, so I will just carry over the r+ that @eddyb left on #54199

[bors]

📌 Commit ffaf7ee has been approved by eddyb

[pietroalbini]

cc @Mark-Simulacrum, should we rollup this in the point release PR instead of landing it on its own?

[Mark-Simulacrum]

@bors r-

Yes, I'd rather not have the stable branch out of sync for too long (and I think that could maybe cause issues with dev-static builds, too).

[weiznich]

Does this also fix #54524?

[nikomatsakis]

@weiznich seems likely, but I haven't tried it yet

[weiznich]

@nikomatsakis After looking at the patch I do not think that this will fix building diesels documentation, because it is the same patch that was applied to nightly some time back. The overflow continues to happen with the latest (rustdoc +nightly --version rustdoc 1.32.0-nightly (451987d 2018-11-01)) nightly.

[nikomatsakis]

@weiznich ah, ok.

[nikomatsakis]

@Mark-Simulacrum ok sorry just let me know how you want to proceed :)

[Mark-Simulacrum]

Essentially we should make this PR have the necessary commits to land on stable and 2-3 days out we'd roll-up all the stable targeting PRs into one and land that. So I think this PR might need some changes perhaps?

[pietroalbini]

@Mark-Simulacrum I don't think there is any fix for the diesel docs regression yet.

[Mark-Simulacrum]

Right, but when/if that happens we'll want to also backport that (perhaps in this PR).