ci: add workflow for uploading installers to release assets #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anqi Pang <[email protected]>
Signed-off-by: Anqi Pang <[email protected]>
Signed-off-by: Anqi Pang <[email protected]>
Signed-off-by: Anqi Pang <[email protected]>
Signed-off-by: Anqi Pang <[email protected]>
Signed-off-by: Anqi Pang <[email protected]>
Signed-off-by: Anqi Pang <[email protected]>
vsiravar
reviewed
Feb 6, 2023
sam-berning
reviewed
Feb 6, 2023
Signed-off-by: Anqi Pang <[email protected]>
AnqiPang
force-pushed
the
anqi/upload-pkg
branch
from
39e7599 to
16c354c
Compare
Signed-off-by: Anqi Pang <[email protected]>
sam-berning
approved these changes
Feb 7, 2023
vsiravar
approved these changes
Feb 7, 2023
|
nit: should be this "ci" isntead of "feat"? |
Oh sorry for the mistake. Do we have any process to rewrite the commit message on main branch? |
|
I think we can fix the release notes at the next release. WDYT? @ningziwen |
|
You can change the commit message release-please uses with this process: https://github.com/googleapis/release-please#how-can-i-fix-release-notes |
AnqiPang
changed the title
|
Following this example PR, I updated the merged PRs #208 and #202 with overridden commit message. Need to validate the release note is fixed after the next release-please run. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This workflow is to be run after the
release-installer.yamlworkflow completes. And after this workflow completes, the next step is to run therelease-homebrew.yamlworkflow. All the three workflows should be merged together once this issue is fixed.Testing done:
Tested the workflow within my own fork.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
BEGIN_COMMIT_OVERRIDE
ci: add workflow for uploading installers to release assets (#208)
END_COMMIT_OVERRIDE