Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Install build dependencies before build for github action: Upload build to S3 #205

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

KevinLiAWS
Copy link
Contributor

@KevinLiAWS KevinLiAWS commented Feb 2, 2023

Issue #, if available:

Description of changes:
The required dependencies are not installed for a new runner when trying to build Finch
Testing done:

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

BEGIN_COMMIT_OVERRIDE

ci: Install build dependencies before build for github action: Upload build to S3

The required dependencies were not installed for a new runner when trying to build Finch.

END_COMMIT_OVERRIDE

@KevinLiAWS KevinLiAWS changed the title Fix Upload build to S3 action for x86_64: install build dependencies before build fix: Install build dependencies before build for github action: Upload build to S3 Feb 2, 2023
AnqiPang
AnqiPang previously approved these changes Feb 2, 2023
Copy link
Contributor

@AnqiPang AnqiPang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KevinLiAWS KevinLiAWS self-assigned this Feb 2, 2023
@KevinLiAWS KevinLiAWS added the bug Something isn't working label Feb 2, 2023
@KevinLiAWS KevinLiAWS enabled auto-merge (squash) February 2, 2023 22:04
@KevinLiAWS KevinLiAWS merged commit 5253f4a into main Feb 2, 2023
@KevinLiAWS KevinLiAWS deleted the fix-uploadtos3-install-dependencies branch February 2, 2023 22:55
@davidhsingyuchen
Copy link
Contributor

nit: this is probably a ci instead of a fix, which should only be used for customer-facing changes. We can follow #208 (comment) to fix this.

@KevinLiAWS KevinLiAWS changed the title fix: Install build dependencies before build for github action: Upload build to S3 ci: Install build dependencies before build for github action: Upload build to S3 Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants