Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tests for finch cp #11

Merged
merged 4 commits into from
Dec 13, 2022

Conversation

mharwani
Copy link
Member

@mharwani mharwani commented Dec 6, 2022

Signed-off-by: Mrudul Harwani [email protected]

Issue #, if available:
runfinch/finch#82

Description of changes:
Adding e2e tests for finch cp command

Testing done:
Tests passed locally

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

BEGIN_COMMIT_OVERRIDE
feat: add tests for finch cp (#11)

Signed-off-by: Mrudul Harwani [email protected]

Issue #, if available:
runfinch/finch#82

Description of changes:
Adding e2e tests for finch cp command

Testing done:
Tests passed locally

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
END_COMMIT_OVERRIDE

Signed-off-by: Mrudul Harwani <[email protected]>
@mharwani mharwani changed the title ci: add e2e tests for finch cp tests: add tests for finch cp Dec 6, 2022
@mharwani mharwani changed the title tests: add tests for finch cp test: add tests for finch cp Dec 6, 2022
tests/cp.go Outdated Show resolved Hide resolved
tests/cp.go Outdated Show resolved Hide resolved
tests/cp.go Outdated Show resolved Hide resolved
tests/cp.go Outdated Show resolved Hide resolved
tests/cp.go Outdated Show resolved Hide resolved
@mharwani mharwani requested a review from azhouwd December 8, 2022 23:37
tests/cp.go Outdated Show resolved Hide resolved
@mharwani mharwani merged commit 3f64815 into runfinch:main Dec 13, 2022
@mharwani mharwani deleted the mharwani/finch-cp-tests branch December 13, 2022 10:30
@azhouwd azhouwd changed the title test: add tests for finch cp feat: add tests for finch cp Dec 13, 2022
mharwani added a commit to runfinch/finch that referenced this pull request Jan 4, 2023
Issue #, if available: #82

*Description of changes:*
Added `finch cp` command and its e2e tests (runfinch/common-tests#11).

*Testing done:*
Unit tests and E2E tests.


- [X] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Mrudul Harwani <[email protected]>
ahsan-z-khan pushed a commit to ahsan-z-khan/finch that referenced this pull request Jan 11, 2023
Issue #, if available: runfinch#82

*Description of changes:*
Added `finch cp` command and its e2e tests (runfinch/common-tests#11).

*Testing done:*
Unit tests and E2E tests.


- [X] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Mrudul Harwani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants