feat: update container runtime archive to nerdctl 2.0.2 #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
feat-container-runtime-full-archive
branch
2 times, most recently
from
c548af1 to
af569f9
Compare
18 tasks
austinvazquez
force-pushed
the
feat-container-runtime-full-archive
branch
from
af569f9 to
aa36717
Compare
Closed
1 task
austinvazquez
force-pushed
the
feat-container-runtime-full-archive
branch
6 times, most recently
from
aaa1d7b to
681dc84
Compare
pendo324
approved these changes
Dec 26, 2024
| - name: Fetch tag for latest release | ||
| id: nerdctl-latest-release | ||
| run: | | ||
| tag=$(git tag --sort=-version:refname | head -n 1) |
There was a problem hiding this comment.
Is there an edge case here, where a new tag is created but it does not have a "release" associated with it yet?
There was a problem hiding this comment.
Good point, it would be caught by our testing in the update PR though.
austinvazquez
force-pushed
the
feat-container-runtime-full-archive
branch
from
681dc84 to
dc86b26
Compare
1 task
austinvazquez
force-pushed
the
feat-container-runtime-full-archive
branch
11 times, most recently
from
5fc8333 to
23ed4be
Compare
1 task
This was referenced Dec 27, 2024
Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
feat-container-runtime-full-archive
branch
from
23ed4be to
83ddcfc
Compare
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
feat-container-runtime-full-archive
branch
from
edfe8de to
badf2e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#475
Description of changes:
This change adds container runtime archive configuration as a tracked dependency with weekly update automation against upstream nerdctl full archives.
This increments on previous efforts to effectively pin Finch's runtime dependencies while implementing a low-cost to develop mechanism to simplify updates.
This change updates the container runtime full archive used in Finch on macOS and Windows to nerdctl v2.0.2. See https://github.com/containerd/nerdctl/releases/tag/v2.0.2 for full details.
Testing done:
Ran
make $(pwd)/_output/lima-template/fedora.yamland verified lima configuration was correct.Ran shellcheck on update container runtime archive script and verified no warnings or errors.
Ran container runtime archive script to update to nerdctl v2.0.2. i.e.
bash bin/update-container-runtime-full-archive.sh -t v2.0.2License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.