feat: create volume command should be idempotent #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
fix-create-volume-test
branch
2 times, most recently
from
c4898b3 to
bd7491e
Compare
coderbirju
approved these changes
Dec 27, 2024
austinvazquez
changed the title
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
fix-create-volume-test
branch
from
bd7491e to
506ca6c
Compare
|
Rebased and edited commit to not be a breaking change. Let me bring this in. Happy to address any feedback in a follow-up PR if required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#198
Description of changes:
This change tests that volume creation is idempotent. Before the behavior was to fail with exit code 1; however, starting with nerdctl 2.0 the expected behavior is to warn users and continue with no error.
Testing done:
Ran test in runfinch/finch-core#472
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.