feat: use finch-core container runtime archive #1232
+32
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pendo324
reviewed
Dec 27, 2024
Makefile
Outdated
| # For Finch on macOS and Windows, the container runtime archive locations and digests are set | ||
| # based on the values set in deps/finch-core/deps/container-runtime-full-archive.conf | ||
| -include $(FINCH_CORE_DIR)/deps/container-runtime-full-archive.conf | ||
| CONTAINER_RUNTIME_ARCHIVE_AARCH64_LOCATION := "$(ARTIFACT_BASE_URL)/$(AARCH64_ARTIFACT)" |
There was a problem hiding this comment.
I think there's value in using ?= for these expressions, in case in dev we need to update them to e.g. test against a new nerdctl version
There was a problem hiding this comment.
Maybe while I have the hood open on this I will go ahead and grab FINCH_IMAGE_LOCATION and FINCH_IMAGE_DIGEST for both platforms as well.
Signed-off-by: Austin Vazquez <[email protected]>
austinvazquez
force-pushed
the
use-finch-core-container-runtime-archive
branch
from
5c71ca1 to
dc9a965
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Container runtime archive updates are currently a two-step process:
Description of changes:
This change updates finch.yaml generation to use the container runtime archive from finch-core.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.