Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of getQuosure3(expr, env, quoted=TRUE) #3466

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Fix handling of getQuosure3(expr, env, quoted=TRUE) #3466

merged 2 commits into from
Jul 16, 2021

Conversation

wch
Copy link
Collaborator

@wch wch commented Jul 16, 2021

Fixes rstudio/shinycoreci-apps#164.

This handles cases where a developer has code like https://github.com/rstudio/DT/blob/c49fb4de687fa60115f16b4d8095c0c972cfc56f/R/shiny.R#L61-L81, where a specific value is used for env or quoted. For example:

  exprToFunction(expr, env, quoted = TRUE)

@wch wch merged commit ed3c676 into master Jul 16, 2021
@wch wch deleted the wch-exprfunction-fix branch July 16, 2021 21:14
@wch wch mentioned this pull request Jul 16, 2021
Closed
5 tasks
@MadhulikaTanuboddi MadhulikaTanuboddi mentioned this pull request Jul 19, 2021
Closed
@schloerke schloerke mentioned this pull request Jul 23, 2021
Merged
4 tasks
@schloerke schloerke mentioned this pull request Aug 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GHA: Apps using "DT::renderTable" failing
1 participant
@wch