-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sustainEnvAndQuoted()
. Remove getQuosure()
#3468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndleEnvAndQuoted3Internal()`
Comment `handleEnvAndQuoted3Internal()` as it is currently not used
wch
reviewed
Jul 23, 2021
wch
reviewed
Jul 23, 2021
wch
reviewed
Jul 23, 2021
Co-authored-by: Winston Chang <[email protected]>
…y do not consistently work
schloerke
changed the title
Allow for
Add Jul 26, 2021
shinyDeprecated()
to know of _superseded_ functionshandleEnvAndQuoted()
. Remove getQuosure()
wch
reviewed
Jul 26, 2021
wch
reviewed
Jul 26, 2021
wch
approved these changes
Jul 26, 2021
We can update the docs in a follow-up PR. |
…dio/shiny into barret/quosure_expr_to_func
schloerke
changed the title
Add
Add Jul 26, 2021
handleEnvAndQuoted()
. Remove getQuosure()
sustainEnvAndQuoted()
. Remove getQuosure()
This was referenced Jul 27, 2021
schloerke
added a commit
that referenced
this pull request
Aug 3, 2021
* master: Update `esbuild-plugin-sass` to latest version (#3463) Interpret NULL discrete limits as NA, fixes #2666 (#2668) Add `sustainEnvAndQuoted()`. Remove `getQuosure()` (#3468) Update NEWS Fix handling of getQuosure3(expr, env, quoted=TRUE) Fix NEWS entry Update NEWS Fix example Update pkgdown.yml Update documentation Add quosure tests for custom render functions Update comment Export getQuosure() and add internal getQuosure3() Rename get_quosure to getQuosure Modify exprToFunction to accept quosures Move expression/quosure functions to utils-lang.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3462
Related: #3466
exprToFunction()
(andinstallExprFunction()
) do not work in all situations and reaching up into the calling code is dangerous / should be avoided. Now, the dangerous code is isolated tosustainEnvAndQuoted()
, which ideally package authors will stop using.With the updated code, all handling will be done with quosures. woot.
Shiny 1.6.0 code
Shiny 1.7.0 migration code
Ideal Shiny 1.7.0 code
Other changes
shinyDeprected()
to know ofsuperseded
functionsrenderDataTable()
exprToFunction()
,installExprFunction()
Remaining:
deprecated()
parametersquoToFunction()
&handleEnvAndQuoted()