Expect rmw_service_server_is_available to ret RMW_RET_INVALID_ARGUMENT #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ros2/rmw#277 changed the
rmw_service_server_is_available()
API documentation to indicate that it returnsRMW_RET_INVALID_ARGUMENT
ifnode
,client
, oris_available
areNULL
. However, this wasn't the case in practice in the implementations ofrmw_service_server_is_available()
or in the relevant test.Change the test here to expect
RMW_RET_INVALID_ARGUMENT
.Required
rmw
implementation PRs:rmw_zenoh
already returnsRMW_RET_INVALID_ARGUMENT
in this case)