Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect rmw_service_server_is_available to ret RMW_RET_INVALID_ARGUMENT #231

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Jun 4, 2024

ros2/rmw#277 changed the rmw_service_server_is_available() API documentation to indicate that it returns RMW_RET_INVALID_ARGUMENT if node, client, or is_available are NULL. However, this wasn't the case in practice in the implementations of rmw_service_server_is_available() or in the relevant test.

Change the test here to expect RMW_RET_INVALID_ARGUMENT.

Required rmw implementation PRs:

@christophebedard
Copy link
Member Author

christophebedard commented Jun 4, 2024

CI with this and the 3 rmw PRs:

  • Linux Build Status
  • Linux-aarch64 Build Status (excludes rmw_connextdds_common)
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator

@sloretz i do not have permission for cyclone and connexdds, can you merge all 4 PRs together?

@clalancette clalancette merged commit 7c17c78 into ros2:rolling Jun 13, 2024
1 of 2 checks passed
@christophebedard christophebedard deleted the christophebedard/rmw-service-server-is-available-ret-invalid-argument branch June 13, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants