Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rmw_service_server_is_available return RMW_RET_INVALID_ARGUMENT #194

Closed
Yadunund opened this issue Jun 4, 2024 · 2 comments
Closed

Make rmw_service_server_is_available return RMW_RET_INVALID_ARGUMENT #194

Yadunund opened this issue Jun 4, 2024 · 2 comments

Comments

@Yadunund
Copy link
Member

Yadunund commented Jun 4, 2024

Follow up to ros2/rmw_implementation#231.

Note: We might need to create iron and jazzy branches, before we adopt this change.
@christophebedard
Copy link
Member

FYI I believe rmw_zenoh_cpp already returns RMW_RET_INVALID_ARGUMENT in this case.

@Yadunund
Copy link
Member Author

Yadunund commented Jun 4, 2024

Oops I didn't check the implementation before I opened this ticket. But glad to see that.

@Yadunund Yadunund closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christophebedard @Yadunund