Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rmw dependencies due to EventsExecutor PR in rcl #255

Merged
merged 8 commits into from
Mar 2, 2022

Conversation

JanStaschulat
Copy link
Contributor

see issue #254

Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
@JanStaschulat JanStaschulat self-assigned this Mar 1, 2022
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
@JanStaschulat
Copy link
Contributor Author

tried several things, but none of them worked:

  • clone rmw repository and build one step before building rclc
  • update ros-tooling/action-ros-ci version to 0.2.4
  • added rmw to package-name

@christophebedard
Copy link
Member

christophebedard commented Mar 1, 2022

I think you can simply add rmw to the existing dependencies.repos file. You don't need to add rmw to package-name, since the source code will all be in the same workspace, and action-ros-ci runs colcon build --packages-up-to $package-name ....

Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
Signed-off-by: Jan Staschulat (CR/ADA1.2) <[email protected]>
@JanStaschulat JanStaschulat changed the title cloning rmw repo temporary Add rmw dependencies due to EventsExecutor PR in rcl Mar 1, 2022
@JanStaschulat JanStaschulat merged commit 4f4590f into master Mar 2, 2022
@JanStaschulat JanStaschulat deleted the bug/ci-rolling-rmw branch March 2, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants