Add Costmap_2d from ROS1 navstack to port from in smaller PRs #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpwilcox
requested review from
mjeronimo,
mkhansenbot,
crdelsey and
mhpanah
Closed
crdelsey
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We talked before about a different approach to merging our large code ports (this is already 10k+ lines) into master. This PR would simply merge the orginal (melodic) ros1 navigation stack code of the costmap_2d package into master (with COLCON_IGNORE so it doesn't build). Our goal would be to make smaller PR edits as we port parts of the code. We could make better use of labels to note when it is build-ready.