Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nav2_costmap_2d: add missing default_value_ copy in Costmap2D operator= #4753

Conversation

DylanDeCoeyer-Quimesis
Copy link
Contributor

default_value_ is an attribute of the Costmap2D class and should be copied along with the other attributes.


Basic Info

Info Please fill out this column
Ticket(s) this addresses /
Primary OS tested on Ubuntu
Robotic platform tested on /
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski
Copy link
Member

@DylanDeCoeyer-Quimesis Please sign off commits with DCO - see the failed CI job for how to do so. Then I can merge :-)

default_value_ is an attribute of the Costmap2D class and should be
copied along with the other attributes.

Signed-off-by: Dylan De Coeyer <[email protected]>
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
nav2_costmap_2d/src/costmap_2d.cpp 87.55% <100.00%> (+0.05%) ⬆️

🚨 Try these New Features:

@SteveMacenski SteveMacenski merged commit e52ea5d into ros-navigation:main Nov 18, 2024
11 checks passed
Jakubach pushed a commit to Jakubach/navigation2 that referenced this pull request Nov 22, 2024
…r= (ros-navigation#4753)

default_value_ is an attribute of the Costmap2D class and should be
copied along with the other attributes.

Signed-off-by: Dylan De Coeyer <[email protected]>
Signed-off-by: Jakubach <[email protected]>
Jakubach pushed a commit to Jakubach/navigation2 that referenced this pull request Nov 22, 2024
…r= (ros-navigation#4753)

default_value_ is an attribute of the Costmap2D class and should be
copied along with the other attributes.

Signed-off-by: Dylan De Coeyer <[email protected]>
Signed-off-by: Jakubach <[email protected]>
Jakubach pushed a commit to Jakubach/navigation2 that referenced this pull request Nov 22, 2024
…r= (ros-navigation#4753)

default_value_ is an attribute of the Costmap2D class and should be
copied along with the other attributes.

Signed-off-by: Dylan De Coeyer <[email protected]>
Signed-off-by: Jakubach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants