Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port voxel layer in nav2_costmap_2d #193

Closed
bpwilcox opened this issue Oct 18, 2018 · 9 comments
Closed

Port voxel layer in nav2_costmap_2d #193

bpwilcox opened this issue Oct 18, 2018 · 9 comments
Assignees
Labels
2 - Medium Medium Priority costmap_2d enhancement New feature or request help wanted Extra attention is needed

Comments

@bpwilcox
Copy link

bpwilcox commented Oct 18, 2018

The voxel layer plugin remains to be ported to ROS2 in the costmap_2d package. The package currently compiles without including this layer. This layer derives from the obstacle layer #192 (which as of this issue is not yet ported), so those dependencies would need to be resolved first.

@mkhansenbot mkhansenbot added the enhancement New feature or request label Oct 18, 2018
@mjeronimo mjeronimo added the help wanted Extra attention is needed label Oct 18, 2018
@prasenjitdan
Copy link

Hi @bpwilcox, In addition to our communication on https://discourse.ros.org/t/voxel-grid-porting-to-ros2/6581, I'm posting here as well. We are happy to help you in porting voxel-grid, so please let me know, if you will be willing to obtain our assistance, and if so, what precisely you would be willing us to take up.

@crdelsey
Copy link
Contributor

There's a voxel_grid package that is part of the ROS 1 navstack. I ported that over to ROS 2 before we started working in the public github repo. I'm assuming it is a dependency to getting the costmap layer working.

If you do in fact need it, let me know and I'll bring it over to this repo. It probably needs some updating to follow our current conventions.

@SteveMacenski
Copy link
Member

SteveMacenski commented Oct 24, 2018

You'll need 3 things

@bpwilcox
Copy link
Author

@prasenjitdan If you're able to coordinate with @SteveMacenski who is working on the obstacle layer, then we'd be glad to accept your contribution on porting the voxel layer plugin.

@SteveMacenski
Copy link
Member

SteveMacenski commented Oct 31, 2018

I posted on the obstacle layer ticket (#192) the branch and status. I'm more than happy to let @prasenjitdan finish the port - it consists of dealing with the parameter while loop semantics and searchign for parameters. I don't know that I'll have the bandwidth to finish that one up anytime soon.

Huge plus is that voxel layer is very simple after obstacle layer is done - since all that hard stuff is done via the obstacle layer

@prasenjitdan
Copy link

@SteveMacenski and @bpwilcox,

At this time, Team is working on 6 packages that we are porting and testing. We have also lined up the next 6 packages for next batch. I can include Voxel Layer replacing one of the identified packages as priorities. I have been given 42 packages to start with, where Obstacle Layer is not part of it. I'm going to check internally and externally to see if we can include " Obstacle Layer". I'll keep you posted.

@bpwilcox
Copy link
Author

@prasenjitdan Since I am going to commit to finishing the obstacle layer port myself, I could continue to do the voxel layer as well, unless you can commit to the port with a timeline in mind for us.

@mkhansenbot mkhansenbot added 1 - High High Priority 2 - Medium Medium Priority and removed 1 - High High Priority labels Nov 12, 2018
@prasenjitdan
Copy link

@bpwilcox, Team is still working on the previous set of packages that includes pcl-ros/perception, xacro, diagnostics-updater/aggregator, libccd, etc. Though we really wanted to extend support in porting obstacle layer and Voxel layer, it will happen only after previous packages are completely ported/tested in ROS2. I really appreciate your initiative on porting Obstacle Layer, and considering porting Voxel layer as well. If you have time, please go ahead with your plan on porting Voxel Layer as well.

@bpwilcox
Copy link
Author

Resolved with #322

ghost pushed a commit to logivations/navigation2 that referenced this issue Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - Medium Medium Priority costmap_2d enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants