-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Ignition Edifice packages #131
Conversation
Signed-off-by: Louise Poubel <[email protected]>
In general I'm very much a fan of fully specified releases since there's really no better expression of what we want in the bootstrap repository than these configs. But since we don't have any enforcement that every clause in a filter expression actually matches a package I can't really justify being dogmatic about it. I think it does make sense to include the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we don't include the debinc value in the fixed portion of the version glob I think it's best to include the debinc separator character -
to prevent unintended matches.
Signed-off-by: Louise Poubel <[email protected]>
Makes sense, added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was one "missed" edit common to both files but other than those it looks good and passes CI.
Signed-off-by: Louise Poubel <[email protected]>
Similar to #129, periodic update to the latest versions.
I'd like to get this in before #128 , to reduce that PR
One thing I did differently here was to remove the revision
-1
from the versions, because some packages were released as-2