Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ignition Fortress #128

Merged
merged 9 commits into from
Dec 22, 2021
Merged

Add Ignition Fortress #128

merged 9 commits into from
Dec 22, 2021

Conversation

chapulina
Copy link
Contributor

Fortress is Ignition's latest LTS and will be the official version to use with Humble, so I'd like to start using Fortress on Rolling soon.

I want to get some more releases in before importing the packages. Opening the PR for visibility.

Part of gazebo-tooling/release-tools#459

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina marked this pull request as ready for review November 17, 2021 19:33
Signed-off-by: Louise Poubel <[email protected]>
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about the target distributions since Rolling is changing in the next 30-60 days but otherwise looks well formed.

@@ -0,0 +1,96 @@
name: ignition_fortress_debian_buster
method: http://packages.osrfoundation.org/gazebo/debian-stable
suites: [buster]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolling is going to switch to Debian Bullseye alongside Ubuntu Jammy. Are we currently building Fortress for Bullseye?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,96 @@
name: ignition_fortress_ubuntu_focal
method: http://packages.osrfoundation.org/gazebo/ubuntu-stable
suites: [focal]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're hoping for Fortress to be upstream in Ubuntu Jammy correct? We'll have these Fortress packages for Focal but over the next month Rolling development will jump over to the Jammy pre-releases and our upstreaming efforts are still underway. I can see some sense in adding Fortress to the bootstrap repo for Jammy in the interim and then removing those packages once they become available upstream. But I have to refresh myself on how hard it is to remove packages from the bootstrap repository and ROS repositories once imported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. One thing to keep in mind though is that relying on upstream will lock us into a fixed version, which wouldn't be great.

I know this has been brought up before, but I'm not sure we got to a consensus. I think ideally we'd have a way to continuously push updates to the Ignition packages consumed by ROS users.

@chapulina
Copy link
Contributor Author

Rolling is changing in the next 30-60 days

It would be really nice to get Fortress into Rolling before that. Can we add it now while we're still on Focal and address Jammy when the time comes?

@nuclearsandwich
Copy link
Contributor

It would be really nice to get Fortress into Rolling before that. Can we add it now while we're still on Focal and address Jammy when the time comes?

That works for me, I just wanted to make sure that you knew the outlook and wanted to spend the effort still.

@chapulina
Copy link
Contributor Author

That works for me, I just wanted to make sure that you knew the outlook and wanted to spend the effort still.

Thanks. We'll deal with Jammy / Bullseye soon. Meanwhile, I think this PR is ready.

Signed-off-by: Louise Poubel <[email protected]>
|
Signed-off-by: Louise Poubel <[email protected]>
)
Signed-off-by: Louise Poubel <[email protected]>
@j-rivero j-rivero merged commit 78a5edd into master Dec 22, 2021
@j-rivero j-rivero deleted the chapulina/fortress branch December 22, 2021 17:32
@j-rivero
Copy link
Contributor

Import to build.ros.org here Build Status

@j-rivero
Copy link
Contributor

ROS2 upload Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants