Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation on melodic by using typedefs #30

Merged
merged 4 commits into from
Aug 30, 2019

Conversation

simonschmeisser
Copy link
Contributor

this fixes compilation on melodic by replacing boost::shared_ptr with the transparent typedefs from MoveIt

see also ros-industrial/fanuc#262

Note that this plugin should probably be replaced with an OPW config ...

gavanderhoorn
gavanderhoorn previously approved these changes Aug 30, 2019
@gavanderhoorn
Copy link
Member

Great. Thanks.

I'll wait for Travis again and squash merge.

@simonschmeisser
Copy link
Contributor Author

this fixes #28

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that the liblapack-dev dependency wasn't already there.

@gavanderhoorn gavanderhoorn merged commit eb81095 into ros-industrial:indigo-devel Aug 30, 2019
@gavanderhoorn
Copy link
Member

Thanks @simonschmeisser 👍

@simonschmeisser simonschmeisser deleted the melodic_compat branch March 29, 2023 18:32
cjue added a commit to isys-vision/motoman that referenced this pull request Aug 17, 2023
cjue added a commit to isys-vision/motoman that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants