add melodic and melodic-testing #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note that this is expected to fail till #30 is merged |
gavanderhoorn
requested changes
Aug 30, 2019
There was a problem hiding this comment.
Thanks for the PR.
Some comments:
this adds melodic as a test target (due to api changes)
Great. Thanks.
and also changes indigo/ros-shadow-fixed to melodic/ros-testing.
Could you please either revert this or do this in a second commit?
For now just adding two new rows for Melodic would be preferred.
simonschmeisser
force-pushed
the
travis_melodic
branch
from
92525bd
to
87e5022
Compare
|
rebased and done |
|
@simonschmeisser: could you rebase again? This should now pass. |
simonschmeisser
force-pushed
the
travis_melodic
branch
from
87e5022
to
f596913
Compare
it does :) |
gavanderhoorn
approved these changes
Aug 30, 2019
|
Thanks @simonschmeisser 👍 🍻 |
|
Glad to contribute :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds melodic as a test target (due to api changes) and also changes indigo/ros-shadow-fixed to melodic/ros-testing. However I have to admit I don't know the full rationale behind listing testing/shadow-fixed here as changes there/in dependencies won't trigger a rebuild?