Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TractionLimiter: Fix wrong input checks #1341

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Nov 1, 2024

While working on ros-controls/control_toolbox#212 and writing tests, I found some issues with the TractionLimiter of the tricycle_controller.

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.47%. Comparing base (f519170) to head (6c7bd61).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
+ Coverage   80.89%   81.47%   +0.57%     
==========================================
  Files         109      110       +1     
  Lines        9696     9821     +125     
  Branches      842      858      +16     
==========================================
+ Hits         7844     8002     +158     
+ Misses       1574     1541      -33     
  Partials      278      278              
Flag Coverage Δ
unittests 81.47% <100.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tricycle_controller/src/traction_limiter.cpp 95.71% <100.00%> (+69.71%) ⬆️
tricycle_controller/test/test_traction_limiter.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@bmagyar bmagyar merged commit 28dd7e1 into master Nov 12, 2024
17 of 19 checks passed
@bmagyar bmagyar deleted the fix/traction_limiter branch November 12, 2024 15:53
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants