Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TractionLimiter: Fix wrong input checks (backport #1341) #1366

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 12, 2024

While working on ros-controls/control_toolbox#212 and writing tests, I found some issues with the TractionLimiter of the tricycle_controller.


This is an automatic backport of pull request #1341 done by Mergify.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 57.29730% with 79 lines in your changes missing coverage. Please review.

Project coverage is 65.29%. Comparing base (2ddb060) to head (3cc7e2a).
Report is 2 commits behind head on humble.

Files with missing lines Patch % Lines
tricycle_controller/test/test_traction_limiter.cpp 54.33% 0 Missing and 79 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           humble    #1366      +/-   ##
==========================================
+ Coverage   65.03%   65.29%   +0.25%     
==========================================
  Files         107      108       +1     
  Lines       12381    12562     +181     
  Branches     7670     7805     +135     
==========================================
+ Hits         8052     8202     +150     
+ Misses       1555     1522      -33     
- Partials     2774     2838      +64     
Flag Coverage Δ
unittests 65.29% <57.29%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tricycle_controller/src/traction_limiter.cpp 95.77% <100.00%> (+73.55%) ⬆️
tricycle_controller/test/test_traction_limiter.cpp 54.33% <54.33%> (ø)

... and 1 file with indirect coverage changes

@bmagyar bmagyar merged commit 5fcc9fd into humble Nov 13, 2024
9 of 12 checks passed
@bmagyar bmagyar deleted the mergify/bp/humble/pr-1341 branch November 13, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants