Fix Travis by using specific version of dependencies #119
Conversation
Use iDynTree commit 6f98701123e66b8fbb274e8e0ae657d7688f7501 taken from robotology/icub-models@b69b989
|
The generation passed by fixing the commits for |
|
As shown in https://github.com/robotology/icub-model-generator/tree/fix-travis-xenial-check , the problem is also fixed by using the current master versions of orocos_kdl and iDynTree, so indeed the problem is due to the |
traversaro
changed the title
|
I think this PR is ready to be reviewed. @prashanthr05 |
| @@ -108,6 +118,7 @@ before_script: | |||
| # urdfdom | |||
| - git clone https://github.com/ros/urdfdom | |||
| - cd urdfdom | |||
| - git checkout 06f5f9bc34f09b530d9f3743cb0516934625da54 | |||
There was a problem hiding this comment.
A small comment about why this commit would go a long way. Thanks.
to quote..
"To fix compilation, we will switch the dependencies to use the commits used in the latest successful model generation"
There was a problem hiding this comment.
It is before, when we switch the commit of console_bridge.
| @@ -100,6 +109,7 @@ before_script: | |||
| # urdfdom_headers | |||
| - git clone https://github.com/ros/urdfdom_headers | |||
| - cd urdfdom_headers | |||
| - git checkout e7e0972a4617b8a5df7a274ea3ba3b92e3895a35 | |||
There was a problem hiding this comment.
A small comment about why this commit would go a long way. Thanks.
to quote...
"To fix compilation, we will switch the dependencies to use the commits used in the latest successful model generation"
| @@ -84,6 +88,7 @@ before_script: | |||
| ## orocos_kdl | |||
| - git clone https://github.com/orocos/orocos_kinematics_dynamics | |||
| - cd orocos_kinematics_dynamics/orocos_kdl | |||
| - git checkout v1.4.0 | |||
There was a problem hiding this comment.
Why the version bump? or downgrade?
to quote ...
"To fix compilation, we will switch the dependencies to use the commits used in the latest successful model generation"
There was a problem hiding this comment.
I will update the travis script with a general comment about how the versions are choosen.
| @@ -75,6 +78,7 @@ before_script: | |||
| ## icub-main | |||
| - git clone https://github.com/robotology/icub-main.git | |||
| - cd icub-main | |||
| - git checkout v1.13.0 | |||
There was a problem hiding this comment.
Why the version bump? or downgrade?
| @@ -66,6 +68,7 @@ before_script: | |||
| ## yarp | |||
| - git clone https://github.com/robotology/yarp.git | |||
| - cd yarp | |||
| - git checkout v3.2.0 | |||
There was a problem hiding this comment.
a comment that we are using the latest version and why?
.travis.yml
Outdated
| @@ -86,7 +86,8 @@ before_script: | |||
| ## orocos_kdl | |||
| - git clone https://github.com/orocos/orocos_kinematics_dynamics | |||
| - cd orocos_kinematics_dynamics/orocos_kdl | |||
| # Go the commit of the 7th Septmber 2018, see | |||
| # Go the commit of the 7th Septmber 2018 for | |||
| # orocos_kdl, console_bridge, urdfdom_headers and urdfdom, see | |||
| # https://travis-ci.org/robotology/icub-model-generator/builds/425819092?utm_source=github_status&utm_medium=notification | |||
| - git checkout f51621f6571e5ad9512ea12741bece39b4ce919b | |||
There was a problem hiding this comment.
Ah okay, it's mostly commented here. Sorry I missed this
|
Added a general comment of versions in ec19498 . I think we can now merge, given your previous approval. @prashanthr05 |
To fix compilation, we will switch the dependencies to use the commits used in the latest successful model generation, see robotology/icub-models@b69b989 . For some dependencies we did not save the exact commit used, but we can infer it from the time of the build at https://travis-ci.org/robotology/icub-model-generator/builds/425819092?utm_source=github_status&utm_medium=notification .