Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis by using specific version of dependencies #119

Merged
merged 6 commits into from
Sep 17, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@ env:
- TRIGGERING_REPOSITORY_URL_VALID_FOR_DEPLOYMENT="https://github.com/robotology/icub-model-generator.git"
- BOT_USER_NAME="LOC2Bot"

# For all dependencies, we use fixed releases to avoid regression due to
# changes in the dependencies. In particular, we use the latest released
# version as of 16 Septembter 2019, except for some dependencies that use
# specific commits, more details are provided in inline comments

before_script:
- if [ "$TRAVIS_OS_NAME" == "linux" ]; then sudo add-apt-repository ppa:nschloe/eigen-backports -y; fi
- if [ "$TRAVIS_OS_NAME" == "linux" ]; then sudo apt-get update; fi
Expand All @@ -48,6 +53,8 @@ before_script:
# install urdf_parser_py and save the last commit SHA1 hash
- git clone $URDF_PARSER_PY_REPOSITORY_URL
- cd urdf_parser_py
# workaround for https://github.com/robotology/simmechanics-to-urdf/issues/36
- git checkout 31474b9baaf7c3845b40e5a9aa87d5900a2282c3
- export URDF_PARSER_PY_COMMIT=`git rev-parse HEAD`
- sudo python setup.py install
- cd ../
Expand All @@ -66,6 +73,7 @@ before_script:
## yarp
- git clone https://github.com/robotology/yarp.git
- cd yarp
- git checkout v3.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment that we are using the latest version and why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- export YARP_COMMIT=`git rev-parse HEAD`
- mkdir build
- cd build
Expand All @@ -75,6 +83,7 @@ before_script:
## icub-main
- git clone https://github.com/robotology/icub-main.git
- cd icub-main
- git checkout v1.13.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the version bump? or downgrade?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- export ICUB_MAIN_COMMIT=`git rev-parse HEAD`
- mkdir build
- cd build
Expand All @@ -84,6 +93,7 @@ before_script:
## orocos_kdl
- git clone https://github.com/orocos/orocos_kinematics_dynamics
- cd orocos_kinematics_dynamics/orocos_kdl
- git checkout v1.4.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the version bump? or downgrade?

to quote ...
"To fix compilation, we will switch the dependencies to use the commits used in the latest successful model generation"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#119 (comment)

I will update the travis script with a general comment about how the versions are choosen.

- mkdir build
- cd build
- cmake ..
Expand All @@ -92,6 +102,10 @@ before_script:
## console_bridge
- git clone https://github.com/ros/console_bridge
- cd console_bridge
# Go the commit of the 7th Septmber 2018 for
# console_bridge, urdfdom_headers and urdfdom, see
# https://travis-ci.org/robotology/icub-model-generator/builds/425819092?utm_source=github_status&utm_medium=notification
- git checkout ad25f7307da76be2857545e7e5c2a20727eee542
- mkdir build
- cd build
- cmake ..
Expand All @@ -100,6 +114,7 @@ before_script:
# urdfdom_headers
- git clone https://github.com/ros/urdfdom_headers
- cd urdfdom_headers
- git checkout e7e0972a4617b8a5df7a274ea3ba3b92e3895a35
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment about why this commit would go a long way. Thanks.

to quote...
"To fix compilation, we will switch the dependencies to use the commits used in the latest successful model generation"

- mkdir build
- cd build
- cmake ..
Expand All @@ -108,6 +123,7 @@ before_script:
# urdfdom
- git clone https://github.com/ros/urdfdom
- cd urdfdom
- git checkout 06f5f9bc34f09b530d9f3743cb0516934625da54
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment about why this commit would go a long way. Thanks.

to quote..
"To fix compilation, we will switch the dependencies to use the commits used in the latest successful model generation"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is before, when we switch the commit of console_bridge.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok!

- mkdir build
- cd build
- cmake ..
Expand All @@ -116,7 +132,7 @@ before_script:
## idyntree
- git clone https://github.com/robotology/idyntree.git
- cd idyntree
- git checkout devel
- git checkout v0.11.1
- export IDYNTREE_COMMIT=`git rev-parse HEAD`
- mkdir build
- cd build
Expand Down