Added custom settings for calibration and visualization options #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrapetti
suggested changes
Mar 7, 2023
There was a problem hiding this comment.
Thanks a lot @dariosortino for the new features.
I added some comments. Remember also to update the Changelog file with a description of the new features!
Co-authored-by: Riccardo Grieco <[email protected]>
Co-authored-by: Riccardo Grieco <[email protected]>
RiccardoGrieco
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Thank you @dariosortino for addressing all the points, I will proceed merging it once all the conversation are resolved.
lrapetti
approved these changes
Mar 19, 2023
|
This new feature might be interesting also for @claudia-lat since in the past we collected some dataset that cannot be calibrated in t-pose, but might be calibrated in n-pose |
|
Thank you everyone, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the title, with @S-Dafarra we included the possibility to define window's Height and Width from the configuration file of the Human State Visualizer. Also, with @lrapetti and @mebbaid we define a new parameter called CalibrationConfig that allows setting custom angles for calibration purposes.