fix: Prevent duplicate extraErrors when not live validating #3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates - Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays - Updated the tests to verify this new feature - Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating - Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282 - Updated `utility-functions.md` to document the new mode - Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262 - Updated the `CHANGELOG.md` accordingly
heath-freenome
changed the title
nickgros
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Approving because this will fix the bug, but a comment for your consideration, @heath-freenome
jacqueswho
approved these changes
Dec 9, 2022
4 tasks
5 tasks
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…m#3288) * fix: Prevent duplicated extraErrors when not live validating Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates - Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays - Updated the tests to verify this new feature - Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating - Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282 - Updated `utility-functions.md` to document the new mode - Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262 - Updated the `CHANGELOG.md` accordingly * - Responded to reviewer feedback * - Fixed url for unpkg directory
shijistar
pushed a commit
to shijistar/react-jsonschema-form
that referenced
this pull request
Jun 8, 2023
…m#3288) * fix: Prevent duplicated extraErrors when not live validating Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates - Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays - Updated the tests to verify this new feature - Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating - Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282 - Updated `utility-functions.md` to document the new mode - Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262 - Updated the `CHANGELOG.md` accordingly * - Responded to reviewer feedback * - Fixed url for unpkg directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Fixed #3169 by merging
extraErrorsin while preventing duplicates@rjsf/utilsto make themergeObjects()function support apreventDuplicatesmode when concatenating arrays@rjsf/coreto use thepreventDuplicatesmode when mergingextraErrorswhen not live validatingvalidation.mdto remove extraneous leading space to fix Localization docs broken #3282utility-functions.mdto document the new modeindex.mdto provide the propercore.cjs.production.min.jspackage name forunpkg.comfixing Documentation for unpkg is incorrect #3262CHANGELOG.mdaccordinglyChecklist
npm run test:updateto update snapshots, if needed.