Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization docs broken #3282

Closed
epicfaace opened this issue Dec 4, 2022 · 0 comments · Fixed by #3288
Closed

Localization docs broken #3282

epicfaace opened this issue Dec 4, 2022 · 0 comments · Fixed by #3288
Assignees
@heath-freenome
Labels
docs

Comments

@epicfaace
Copy link
Member

See https://react-jsonschema-form.readthedocs.io/en/latest/usage/validation/#some-examples

image
@github-actions github-actions bot added the needs triage Initial label given, to be assigned correct labels and assigned label Dec 4, 2022
@heath-freenome heath-freenome added docs and removed needs triage Initial label given, to be assigned correct labels and assigned labels Dec 8, 2022
@heath-freenome heath-freenome self-assigned this Dec 8, 2022
heath-freenome added a commit to heath-freenome/react-jsonschema-form that referenced this issue Dec 8, 2022
@heath-freenome
fix: Prevent duplicated extraErrors when not live validating
0abca05 
Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates
- Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays
  - Updated the tests to verify this new feature
- Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating
- Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282
- Updated `utility-functions.md` to document the new mode
- Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262
- Updated the `CHANGELOG.md` accordingly
@heath-freenome heath-freenome mentioned this issue Dec 8, 2022
Merged
8 tasks
heath-freenome added a commit that referenced this issue Dec 9, 2022
@heath-freenome
fix: Prevent duplicate extraErrors when not live validating (#3288)
fc6a5ae 
* fix: Prevent duplicated extraErrors when not live validating
Fixed #3169 by merging `extraErrors` in while preventing duplicates
- Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays
  - Updated the tests to verify this new feature
- Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating
- Updated `validation.md` to remove extraneous leading space to fix #3282
- Updated `utility-functions.md` to document the new mode
- Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing #3262
- Updated the `CHANGELOG.md` accordingly

* - Responded to reviewer feedback

* - Fixed url for unpkg directory
shijistar pushed a commit to shijistar/react-jsonschema-form that referenced this issue Jun 8, 2023
@heath-freenome
fix: Prevent duplicate extraErrors when not live validating (rjsf-tea…
9130fce 
…m#3288)

* fix: Prevent duplicated extraErrors when not live validating
Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates
- Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays
  - Updated the tests to verify this new feature
- Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating
- Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282
- Updated `utility-functions.md` to document the new mode
- Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262
- Updated the `CHANGELOG.md` accordingly

* - Responded to reviewer feedback

* - Fixed url for unpkg directory
shijistar pushed a commit to shijistar/react-jsonschema-form that referenced this issue Jun 8, 2023
@heath-freenome
fix: Prevent duplicate extraErrors when not live validating (rjsf-tea…
b81bbc0 
…m#3288)

* fix: Prevent duplicated extraErrors when not live validating
Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates
- Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays
  - Updated the tests to verify this new feature
- Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating
- Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282
- Updated `utility-functions.md` to document the new mode
- Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262
- Updated the `CHANGELOG.md` accordingly

* - Responded to reviewer feedback

* - Fixed url for unpkg directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heath-freenome heath-freenome

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Prevent duplicate extraErrors when not live validating heath-freenome/react-jsonschema-form
2 participants
@epicfaace @heath-freenome