-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for unpkg is incorrect #3262
Comments
Can you update your fiddle to use the latest |
@heath-freenome Can you point me to the URL I need? I tried to use the one from the docs which is https://unpkg.com/@rjsf/core/dist/react-jsonschema-form.js - but it doesn't seem to exist |
Can you try using |
Thanks for getting abck to me. It looks like the file So should I just use |
So we have a doc issue to fix... and yes use that one instead |
Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates - Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays - Updated the tests to verify this new feature - Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating - Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282 - Updated `utility-functions.md` to document the new mode - Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262 - Updated the `CHANGELOG.md` accordingly
Just tried to reproduce in CodePen and you're right it doesn't happen in
which works well. Here is the CodePen if you are interested,. Thanks for your time with this. |
* fix: Prevent duplicated extraErrors when not live validating Fixed #3169 by merging `extraErrors` in while preventing duplicates - Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays - Updated the tests to verify this new feature - Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating - Updated `validation.md` to remove extraneous leading space to fix #3282 - Updated `utility-functions.md` to document the new mode - Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing #3262 - Updated the `CHANGELOG.md` accordingly * - Responded to reviewer feedback * - Fixed url for unpkg directory
Fixed the doc issue with #3288 |
…m#3288) * fix: Prevent duplicated extraErrors when not live validating Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates - Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays - Updated the tests to verify this new feature - Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating - Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282 - Updated `utility-functions.md` to document the new mode - Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262 - Updated the `CHANGELOG.md` accordingly * - Responded to reviewer feedback * - Fixed url for unpkg directory
…m#3288) * fix: Prevent duplicated extraErrors when not live validating Fixed rjsf-team#3169 by merging `extraErrors` in while preventing duplicates - Updated `@rjsf/utils` to make the `mergeObjects()` function support a `preventDuplicates` mode when concatenating arrays - Updated the tests to verify this new feature - Updated `@rjsf/core` to use the `preventDuplicates` mode when merging `extraErrors` when not live validating - Updated `validation.md` to remove extraneous leading space to fix rjsf-team#3282 - Updated `utility-functions.md` to document the new mode - Updated `index.md` to provide the proper `core.cjs.production.min.js` package name for `unpkg.com` fixing rjsf-team#3262 - Updated the `CHANGELOG.md` accordingly * - Responded to reviewer feedback * - Fixed url for unpkg directory
Prerequisites
What theme are you using?
mui
Version
^4.1.1 locally but latest on the JSFiddle - https://jsfiddle.net/mdeazLy3/1/
Current Behavior
Error stacks are being truncated if a custom validation function is used, even if the function doesn't modify the
errors
objectExpected Behavior
Error stacks should stay the same
Steps To Reproduce
See this JSFiddle - https://jsfiddle.net/mdeazLy3/1/
Environment
Anything else?
Form on the right has a custom validate function that does nothing (just returns
errors
as per the docs). The forms share a schema. To see the schema and the forms please see the JSFiddle here - https://jsfiddle.net/mdeazLy3/1/The text was updated successfully, but these errors were encountered: