Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DescriptionField customization #2591

Closed
wants to merge 2 commits into from
Closed

Conversation

alex-pex
Copy link

@alex-pex alex-pex commented Oct 28, 2021

Reasons for making this change

Using a description with a FixedArray and a custom theme (mui, boostrap, ...) crashes.
This fix the problem at the source. That's why it replaces #2451

Fixes #2481, #2363, #2219

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@alex-pex
Copy link
Author

alex-pex commented Oct 28, 2021

You can reproduce the bug with this schema

{
  "type": "object",
  "additionalProperties": false,
  "properties": {
    "features": {
      "$ref": "#/definitions/features__core_workspace_calendar"
    }
  },
  "definitions": {
    "features__core_workspace_calendar": {
      "title": "Espace de travail : Calendrier [CWC-514]",
      "description": "Gestion des horaires journaliers",
      "type": "array",
      "items": [
        {
          "type": "boolean",
          "default": false
        }
      ]
    }
  }
}

and switching to bootstrap4 theme

@ssbyoung
Copy link

ssbyoung commented Mar 3, 2022

@newt10 can you take a look at this PR?

@alex-pex
Copy link
Author

Hi! I updated the PR, can someone do a review? I'm using a patched version for the moment

@alex-pex alex-pex force-pushed the patch-1 branch 3 times, most recently from e316865 to 0819382 Compare May 16, 2022 14:22
@alex-pex alex-pex requested a review from epicfaace May 20, 2022 12:23
@alex-pex
Copy link
Author

@epicfaace do I need to do something else? for me the PR is ready for review (I updated the tests as asked)

@heath-freenome
Copy link
Member

Fixed in the v5 beta, see the 5.x migration guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom DescriptionField not working, Unable to render Icons with Description in Form
4 participants