-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DescriptionField customization #2591
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can reproduce the bug with this schema
and switching to bootstrap4 theme |
@newt10 can you take a look at this PR? |
2 tasks
Hi! I updated the PR, can someone do a review? I'm using a patched version for the moment |
epicfaace
reviewed
Apr 28, 2022
alex-pex
force-pushed
the
patch-1
branch
3 times, most recently
from
May 16, 2022 14:22
e316865
to
0819382
Compare
alex-pex
commented
May 16, 2022
epicfaace
reviewed
Jun 1, 2022
@epicfaace do I need to do something else? for me the PR is ready for review (I updated the tests as asked) |
Fixed in the v5 beta, see the 5.x migration guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Using a description with a FixedArray and a custom theme (mui, boostrap, ...) crashes.
This fix the problem at the source. That's why it replaces #2451
Fixes #2481, #2363, #2219
Checklist