Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom description not rendering appropriately in semantic-ui #2451

Conversation

ssbyoung
Copy link

Reasons for making this change

fixes #2363

@newt10 newt10 added the semantic-ui semantic-ui related theme issue label Sep 3, 2021
@newt10
Copy link
Collaborator

newt10 commented Sep 3, 2021

@ssbyoung , can you add tests to ensure that we can catch these in the future and prevent regressions.

@newt10 newt10 added labelOrDescription Relating to labels and descriptions of fields in the form awaiting changes labels Sep 3, 2021
@newt10 newt10 self-requested a review September 3, 2021 19:19
Copy link
Collaborator

@newt10 newt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to ensure that we do not have regressions for this in the future

alex-pex added a commit to alex-pex/react-jsonschema-form that referenced this pull request Oct 28, 2021
@alex-pex alex-pex mentioned this pull request Oct 28, 2021
8 tasks
@ssbyoung
Copy link
Author

ssbyoung commented Mar 3, 2022

Closing this in favor of #2591

@ssbyoung ssbyoung closed this Mar 3, 2022
@ssbyoung ssbyoung deleted the ssbyoung/fix-semantic-ui-descriptions branch March 3, 2022 16:09
alex-pex added a commit to alex-pex/react-jsonschema-form that referenced this pull request May 11, 2022
alex-pex added a commit to alex-pex/react-jsonschema-form that referenced this pull request May 11, 2022
alex-pex added a commit to alex-pex/react-jsonschema-form that referenced this pull request May 16, 2022
alex-pex added a commit to alex-pex/react-jsonschema-form that referenced this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes labelOrDescription Relating to labels and descriptions of fields in the form semantic-ui semantic-ui related theme issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Semantic-ui] Field descriptions are not getting custom description rendering
2 participants