Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Semantic-ui] Field descriptions are not getting custom description rendering #2363

Closed
2 tasks done
ssbyoung opened this issue May 5, 2021 · 6 comments
Closed
2 tasks done
Labels
bug labelOrDescription Relating to labels and descriptions of fields in the form

Comments

@ssbyoung
Copy link

ssbyoung commented May 5, 2021

Prerequisites

  • I have read the documentation;
  • In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

This is the SSCCE that shows this behavior.
rjsf-description-issue.zip

Description

When providing a custom DescriptionField to the SemanticUI version of the form, it does not get parsed on field level descriptions.

Steps to Reproduce

  1. Use the @rjfs/semantic-ui form and pass in fields with a DescriptionField

Expected behavior

I would expect the description to go through my custom field.

Actual behavior

rjsf bug

Version

2.5.1 for both @rjsf/core and @rjsf/semantic-ui

@trebor
Copy link

trebor commented May 24, 2021

i also see the same problem in material-UI:

import Form from "@rjsf/material-ui";

both <TitleField /> and <DescriptionField /> are properly used as i would expect at the top level of the from, but not in any of the form fields as they do work with @rjsf/core.

@ssbyoung
Copy link
Author

@trebor I suspect that this affects all the themes, but I didn't check.

@JonSilver
Copy link

Duplicate of #2219

@ssbyoung
Copy link
Author

I've fixed this in #2451

I feel like the other themes are doing similar things where they are just displaying raw text and not using the registry to get the proper description component.

@newt10 newt10 added bug labelOrDescription Relating to labels and descriptions of fields in the form labels Sep 3, 2021
alex-pex added a commit to alex-pex/react-jsonschema-form that referenced this issue Oct 28, 2021
@ssbyoung
Copy link
Author

ssbyoung commented Mar 3, 2022

In general I think #2591 was a better solution than what I came up with. Please get that PR out the door instead.

alex-pex added a commit to alex-pex/react-jsonschema-form that referenced this issue May 11, 2022
alex-pex added a commit to alex-pex/react-jsonschema-form that referenced this issue May 11, 2022
alex-pex added a commit to alex-pex/react-jsonschema-form that referenced this issue May 16, 2022
alex-pex added a commit to alex-pex/react-jsonschema-form that referenced this issue Jun 10, 2022
@heath-freenome
Copy link
Member

Fixed in the v5 beta, see the 5.x migration guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug labelOrDescription Relating to labels and descriptions of fields in the form
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants