Runtime: Adds decimal256 support
#3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-anshul
changed the title
decimal256 supportdecimal256 support
nishantmonu51
approved these changes
Nov 30, 2023
begelundmuller
requested changes
Nov 30, 2023
Comment on lines
350
to
355
| num, _ := r.Float64() | ||
| if math.IsInf(num, 0) { | ||
| row[f] = r.FloatString(38) | ||
| } else { | ||
| row[f] = num | ||
| } |
There was a problem hiding this comment.
This will only work for numbers fitting in a float64. Is there any chance we can improve precision here?
One idea (haven't tried it, just based on looking at the docs) is:
n := new(big.Float)
n.SetRat(r)
row[f] = n.String()There was a problem hiding this comment.
No. The if part takes car of outputting numbers of arbitrary precision and width. I chose 38 which is the max precision for decimal256.
I am eagerly trying to see if the number can fit in float64 so that those numbers are output as float instead of varchar. I am assuming if users have problem casting columns in submitted sql they would have problem casting in model as well. Also I am suspecting most columns marked as BigNumeric would rarely need such high precisions.
r := big.NewRat(1, 2)
_, ok := r.SetString("5.7896044618658097711785492504343953926634992332820282019728792003956564819967E+38")
if !ok {
panic("yellow")
}
fmt.Println(r.FloatString(38)) // prints 578960446186580977117854925043439539266.34992332820282019728792003956564819967
n := new(big.Float)
n.SetRat(r)
fmt.Println(n.SetPrec(38).String()) // prints 5.789604462e+38
* test * inital commit * nit changes * fix test and linter * small changes * Added test for org switch * changes for output as csv * added test for service cmd * linter fix * test sleep * increased sleep time to test * tidy * test * added tests for user command * other commands added with helper * nit * removed unwanted comments * few changes * nit * updated printer functions * nit * review changes * nit * PR changes * nit * ci fix
begelundmuller
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3528