Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3008 cli implement end to end tests #3221

Merged
merged 36 commits into from
Nov 30, 2023

Conversation

rakeshsharma14317
Copy link
Contributor

No description provided.

@rakeshsharma14317 rakeshsharma14317 linked an issue Oct 11, 2023 that may be closed by this pull request
@rakeshsharma14317 rakeshsharma14317 marked this pull request as ready for review October 17, 2023 09:33
@coderabbitai
Copy link

coderabbitai bot commented Oct 31, 2023

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. Skipping review to prevent low quality review.

31 files out of 88 files are above the max files limit of 50.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@rakeshsharma14317 rakeshsharma14317 self-assigned this Oct 31, 2023
@begelundmuller begelundmuller requested review from k-anshul and removed request for begelundmuller November 10, 2023 09:39
cli/cmd/admin/ping.go Outdated Show resolved Hide resolved
cli/cmd/project/show.go Outdated Show resolved Hide resolved
cli/cmd/project/status.go Outdated Show resolved Hide resolved
cli/cmd/root.go Outdated Show resolved Hide resolved
cli/cmd/service/list.go Outdated Show resolved Hide resolved
cli/pkg/printer/printer.go Outdated Show resolved Hide resolved
cli/pkg/printer/printer.go Outdated Show resolved Hide resolved
cli/pkg/printer/printer.go Show resolved Hide resolved
cli/pkg/printer/printer.go Outdated Show resolved Hide resolved
Copy link
Member

@k-anshul k-anshul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also some test cases are failing now.

cli/cmd/project/rename.go Show resolved Hide resolved
cli/cmd/project/status.go Outdated Show resolved Hide resolved
cli/cmd/root.go Show resolved Hide resolved
cli/pkg/printer/printer.go Outdated Show resolved Hide resolved
@k-anshul
Copy link
Member

LGTM. Could you please take a look at this comment.
And also resolve conflicts in go.sum

@nishantmonu51
Copy link
Collaborator

Looks good to be merged, @rakeshsharma14317 : Lets resolve conflicts and merge.

@rakeshsharma14317 rakeshsharma14317 merged commit e5e7883 into main Nov 30, 2023
4 checks passed
@rakeshsharma14317 rakeshsharma14317 deleted the 3008-cli-implement-end-to-end-tests branch November 30, 2023 10:51
k-anshul pushed a commit that referenced this pull request Nov 30, 2023
* test

* inital commit

* nit changes

* fix test and linter

* small changes

* Added test for org switch

* changes for output as csv

* added test for service cmd

* linter fix

* test sleep

* increased sleep time to test

* tidy

* test

* added tests for user command

* other commands added with helper

* nit

* removed unwanted comments

* few changes

* nit

* updated printer functions

* nit

* review changes

* nit

* PR changes

* nit

* ci fix
begelundmuller added a commit that referenced this pull request Nov 30, 2023
* decimal256_support

* Upgrade bigquery sdk for native arrow interface support (#3588)

* Docs: regenerate CLI reference (#3585)

* 3008 cli implement end to end tests (#3221)

* test

* inital commit

* nit changes

* fix test and linter

* small changes

* Added test for org switch

* changes for output as csv

* added test for service cmd

* linter fix

* test sleep

* increased sleep time to test

* tidy

* test

* added tests for user command

* other commands added with helper

* nit

* removed unwanted comments

* few changes

* nit

* updated printer functions

* nit

* review changes

* nit

* PR changes

* nit

* ci fix

* review comments

* removing decimal256 check from snowflake as well

---------

Co-authored-by: Benjamin Egelund-Müller <[email protected]>
Co-authored-by: Rakesh Sharma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Implement end-to-end tests
3 participants