Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3587 regression in v0.40.0 #3966

Closed
AndrewRTsao opened this issue Feb 4, 2024 · 0 comments · Fixed by #3967
Closed

Fix 3587 regression in v0.40.0 #3966

AndrewRTsao opened this issue Feb 4, 2024 · 0 comments · Fixed by #3967
Assignees
Labels
customer Type:Bug Something isn't working

Comments

@AndrewRTsao
Copy link
Contributor

Describe the bug
It seems like v0.40.0 has introduced a regression for the fix we previously made in #3587 (to natively cast and allow support for BIGNUMERIC type). This should theoretically be separately fixed by DuckDB #9770 once the new major release of DuckDB is available but is currently customer impacting so we should still make the same fix that we made previously to resolve #3528.

Steps to Reproduce

  1. Create a table in BQ that contains some BIGNUMERIC columns
  2. Create a datasource in Rill Developer that reads from this BQ table (without applying a cast)

Expected Behavior: Rill Developer should be able to read this BQ datasource
Actual Behavior: Rill Developer throws an INTERNAL ERROR: Decimal has a width of 76 which is bigger than the maximum supported width of 38

Verified that it works in v0.39.1 but not v0.40.0 (pointing to the exact same BQ source). See screenshots below.
v0 39 1
v0 40 0

@AndrewRTsao AndrewRTsao added Type:Bug Something isn't working customer labels Feb 4, 2024
@k-anshul k-anshul linked a pull request Feb 5, 2024 that will close this issue
@k-anshul k-anshul closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants