Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add communities to rsd #1182

Merged
merged 9 commits into from
Jun 13, 2024
Merged

Add communities to rsd #1182

merged 9 commits into from
Jun 13, 2024

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Apr 29, 2024

RSD communites

This PR implements first version of communities into RSD. By default the communities are not "enabled".

Closes #616
Closes #1183
Closes #1184
Closes #1185
Closes #1189
Closes #1196
Closes #1214
Closes #1215

Changes proposed in this pull request:

  • RSD admin can create a new community
  • RSD admin can delete a community (which has no software relation)
  • Community admin can changes settings, invite maintainers and create about page
  • Community admin can accept/reject software requests to join the community
  • All visitors can view and filter all software entries of the community

How to test:

  • enable "communities" in the settings.json
  • make start to build the solution and create some test data (although test data is not required)
  • test basic functionality as described in feat: add communities to edit software #1220

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@ewan-escience ewan-escience removed their request for review April 30, 2024 07:59
@jmaassen
Copy link
Member

jmaassen commented May 1, 2024

Works well. I'm not sure if the 300 character short description is sufficient, but we'll figure that out once we start testing with actual content

@dmijatovic dmijatovic changed the title Add communities to rsd admin section Add communities to rsd May 13, 2024
@dmijatovic dmijatovic force-pushed the 616-communities branch 3 times, most recently from ab34bb9 to 20523b6 Compare June 4, 2024 11:41
@dmijatovic dmijatovic requested a review from ewan-escience June 10, 2024 09:05
@dmijatovic dmijatovic marked this pull request as ready for review June 10, 2024 09:06
@dmijatovic dmijatovic requested review from cmeessen and fembau June 10, 2024 09:07
dmijatovic and others added 8 commits June 10, 2024 14:44
feat: implement communities overview, grid and list incl. search on name and short description
chore: add communities to data generation and small SQL style fixes
---------

Co-authored-by: Ewan Cahen <[email protected]>
feat: implement community settings page
chore: refactor maintainers sections
fix: do not show highlights section when javascript is disabled
chore: add row level security for communities and improve database functions
feat: add community keywords (#1199)
feat: add community keywords
chore: improve SQL and add keywords for communities to data generation

---------

Co-authored-by: Ewan Cahen <[email protected]>

---------

Co-authored-by: Ewan Cahen <[email protected]>
…tware page (#1213)

feat: add seprate tabs for pending requests and rejected requirest
fix: data generation fix formatting (main.js)
feat: improve delete of communities in admin section
docs: add communities to documentation
chore: update docusaurus and lock versions
chore: remove communities from modules
fix: revert back font size when less than 4 items in the menu
fix: remove unused variable
test: fix broken test and extend with communties check
note: communties is disabled by default
chore: bump rsd-frontent verion.
chore: next.js to latest version
@dmijatovic dmijatovic force-pushed the 616-communities branch 2 times, most recently from d2a43a4 to 3c05bc4 Compare June 10, 2024 15:25
…tainers, improve link button on invite confirmation page
Copy link

Quality Gate Passed Quality Gate passed for 'rsd-database'

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
10.2% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'rsd-frontend'

Failed conditions
11.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@ewan-escience ewan-escience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nce work! We should do #1222 and #1223 soon after this, though.

@dmijatovic
Copy link
Contributor Author

@cmeessen and @fembau I would like to merge this PR today EOD. I assume you do not have any objections. Please note that the next version will require modules definition in the settings file in order to hide communities module.

@dmijatovic dmijatovic merged commit 17ade2a into main Jun 13, 2024
6 of 7 checks passed
@dmijatovic dmijatovic deleted the 616-communities branch July 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants