Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement communities overview #1188

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented May 2, 2024

Implement community overview

Closes #1183

Changes proposed in this pull request:

  • Create communities overview
  • Add Communities menu option at the header and in the mobile menu
  • Refactor app header layout
    • Created desktop en mobile menu options
    • Feedback button is always present as separate option
    • Desktop menu options are shown on large screen (>= 1024px) 
  • Increased number of test items for news in order to test pagination
  • Add news and communities links to the page footer
  • Scaffolded community page (but is not completed in this PR)

How to test:

  • make start to build app and generate data
  • login as rsd-admin
  • navigate to administration section and create few communities
  • view communities overview, try grid/list view, items per page, pagination (you will need to create 12+ items)
  • try search option (name and short description)

Example communities overview

image

To do!

The community page is not implemented. This page is more complex and will be finalized in the next PR. In this PR you only see partially completed page

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@dmijatovic dmijatovic changed the title feat: implement communities overview, grid and list incl. search on n… Implement communities overview May 2, 2024
@jmaassen
Copy link
Member

jmaassen commented May 2, 2024

Works well. Not sure if the software counter in the middle is the best place? But lets discuss that later.

@dmijatovic dmijatovic force-pushed the 1183-communities-overview branch 2 times, most recently from d1854f3 to d07edd7 Compare May 2, 2024 08:02
@dmijatovic dmijatovic force-pushed the 1183-communities-overview branch from d07edd7 to 256de4e Compare May 2, 2024 08:35
Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed for 'rsd-database'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarqubecloud bot commented May 2, 2024

Quality Gate Failed Quality Gate failed for 'rsd-frontend'

Failed conditions
11.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dmijatovic dmijatovic merged commit f229d0e into 616-communities May 2, 2024
5 of 6 checks passed
dmijatovic added a commit that referenced this pull request May 17, 2024
* feat: implement communities overview, grid and list incl. search on name and short description

* chore: add communities to data generation and small SQL style fixes

---------

Co-authored-by: Ewan Cahen <[email protected]>
dmijatovic added a commit that referenced this pull request May 30, 2024
feat: implement communities overview, grid and list incl. search on name and short description
chore: add communities to data generation and small SQL style fixes
---------

Co-authored-by: Ewan Cahen <[email protected]>
@dmijatovic dmijatovic deleted the 1183-communities-overview branch May 30, 2024 14:26
dmijatovic added a commit that referenced this pull request Jun 4, 2024
feat: implement communities overview, grid and list incl. search on name and short description
chore: add communities to data generation and small SQL style fixes
---------

Co-authored-by: Ewan Cahen <[email protected]>
dmijatovic added a commit that referenced this pull request Jun 10, 2024
feat: implement communities overview, grid and list incl. search on name and short description
chore: add communities to data generation and small SQL style fixes
---------

Co-authored-by: Ewan Cahen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants